bpo-43224: Implement substitution of unpacked TypeVarTuple in C#31828
bpo-43224: Implement substitution of unpacked TypeVarTuple in C#31828serhiy-storchaka merged 5 commits into
Conversation
|
Thanks for working on this! Please don't merge this without approval from the PEP 646 authors or the typing experts; I'm not confident we'll get all the edge cases right. I'd have liked a chance to review #31800 in more detail too. |
Sorry, something went wrong.
JelleZijlstra
left a comment
There was a problem hiding this comment.
I found a crash; see comment.
In general I'm worried that this approach will be too difficult to get right in all cases. I'd prefer the approach in #31804, which I suggested in #31021 (review).
Sorry, something went wrong.
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be poked with soft cushions! |
Sorry, something went wrong.
|
I have made the requested changes; please review again. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @JelleZijlstra: please review the changes made to this pull request. |
Sorry, something went wrong.
|
Wow, thanks for implementing this - it hadn't even occurred to me this would be needed! I also feel uneasy, though - as I mentioned in #31800 we'd decided against implementing it this way. I think we should pause work on this until we've decided on exactly which approach we're proceeding with. |
Sorry, something went wrong.
|
Based on your note in #31800, I'm guessing you're going to proceed with this anyway. In that case, I think it would be worth adding some tests to this PR along the lines of b9b1c80#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305dL794. |
Sorry, something went wrong.
|
I do not understand what tests are in question. The change you referred removes tests, not adds new tests. |
Sorry, something went wrong.
|
Right - I'm proposing adding them back, with the changes necessary to also test the code in this PR. |
Sorry, something went wrong.
(Code by Matthew Rahtz) Co-authored-by: Matthew Rahtz <mrahtz@gmail.com>
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 0b9a4d3 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
https://bugs.python.org/issue43224