◐ Shell
reader mode source ↗
Skip to content

bpo-43224: Implement substitution of unpacked TypeVarTuple in C#31828

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:typevartuple-subst-c
Apr 30, 2022
Merged

bpo-43224: Implement substitution of unpacked TypeVarTuple in C#31828
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:typevartuple-subst-c

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 11, 2022

Copy link
Copy Markdown
Member

@JelleZijlstra

Copy link
Copy Markdown
Member

Thanks for working on this! Please don't merge this without approval from the PEP 646 authors or the typing experts; I'm not confident we'll get all the edge cases right. I'd have liked a chance to review #31800 in more detail too.

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I found a crash; see comment.

In general I'm worried that this approach will be too difficult to get right in all cases. I'd prefer the approach in #31804, which I suggested in #31021 (review).

@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

@mrahtz

mrahtz commented Mar 12, 2022

Copy link
Copy Markdown
Contributor

Wow, thanks for implementing this - it hadn't even occurred to me this would be needed!

I also feel uneasy, though - as I mentioned in #31800 we'd decided against implementing it this way. I think we should pause work on this until we've decided on exactly which approach we're proceeding with.

@mrahtz

mrahtz commented Mar 13, 2022

Copy link
Copy Markdown
Contributor

Based on your note in #31800, I'm guessing you're going to proceed with this anyway. In that case, I think it would be worth adding some tests to this PR along the lines of b9b1c80#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305dL794.

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

I do not understand what tests are in question. The change you referred removes tests, not adds new tests.

@mrahtz

mrahtz commented Mar 13, 2022

Copy link
Copy Markdown
Contributor

Right - I'm proposing adding them back, with the changes necessary to also test the code in this PR.

JelleZijlstra and others added 2 commits April 29, 2022 14:04
(Code by Matthew Rahtz)

Co-authored-by: Matthew Rahtz <mrahtz@gmail.com>
@JelleZijlstra JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 0b9a4d3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@serhiy-storchaka serhiy-storchaka merged commit e8c2f72 into python:main Apr 30, 2022
@serhiy-storchaka serhiy-storchaka deleted the typevartuple-subst-c branch April 30, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news topic-typing type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants