◐ Shell
reader mode source ↗
Skip to content

bpo-46906: Mention PY_BIG_ENDIAN in PyFloat_Pack8() doc#31832

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:doc_float_native
Closed

bpo-46906: Mention PY_BIG_ENDIAN in PyFloat_Pack8() doc#31832
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:doc_float_native

Conversation

@vstinner

@vstinner vstinner commented Mar 12, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Mar 12, 2022
@vstinner vstinner mentioned this pull request Mar 12, 2022
Merged
@vstinner

vstinner commented Mar 12, 2022

Copy link
Copy Markdown
Member Author

cc @arhadthedev @methane @mdickinson

@vstinner

vstinner commented Mar 12, 2022

Copy link
Copy Markdown
Member Author

I noticed that PY_BIG_ENDIAN can be used while writing a PR for bitstruct :-) https://github.com/eerimoq/bitstruct/pull/26/files

mdickinson
mdickinson approved these changes Mar 13, 2022
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Changes LGTM. I do agree with @JelleZijlstra that it's potentially confusing, but I don't see a solution to that other than renaming PY_BIG_ENDIAN.

@vstinner vstinner mentioned this pull request Mar 14, 2022
Merged
@vstinner

vstinner commented Mar 14, 2022

Copy link
Copy Markdown
Member Author

I merged the PR #31866 instead.

@vstinner vstinner closed this Mar 14, 2022
@vstinner vstinner deleted the doc_float_native branch March 14, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

+2 more reviewers

@mdickinson mdickinson mdickinson approved these changes

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner @mdickinson @JelleZijlstra @raghavthind2005 @the-knights-who-say-ni @bedevere-bot