◐ Shell
reader mode source ↗
Skip to content

[3.5] bpo-31095: fix potential crash during GC#3196

Merged
larryhastings merged 3 commits into
python:3.5from
methane:backport-a6296d3-3.5
Sep 26, 2017
Merged

[3.5] bpo-31095: fix potential crash during GC#3196
larryhastings merged 3 commits into
python:3.5from
methane:backport-a6296d3-3.5

Conversation

@methane

@methane methane commented Aug 24, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit a6296d3)

https://bugs.python.org/issue31095

@methane methane requested a review from larryhastings August 24, 2017 07:02
@larryhastings larryhastings requested a review from zooba September 25, 2017 01:31
@larryhastings

larryhastings commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

Hi, Steve, this is failing on link, can you look in to it?

@methane

methane commented Sep 25, 2017

Copy link
Copy Markdown
Member Author

Link error message in AppVeyor:

[00:03:36]   Finished generating code
[00:03:37]      Creating library C:\projects\cpython\PCBuild\win32\_elementtree.lib and object C:\projects\cpython\PCBuild\win32\_elementtree.exp
[00:03:37] xmlparse.obj : error LNK2001: unresolved external symbol __Expat_LoadLibrary [C:\projects\cpython\PCbuild\_elementtree.vcxproj]
[00:03:37] C:\projects\cpython\PCBuild\win32\_elementtree.pyd : fatal error LNK1120: 1 unresolved externals [C:\projects\cpython\PCbuild\_elementtree.vcxproj]

@zooba

zooba commented Sep 25, 2017

Copy link
Copy Markdown
Member

Looks like the pyexpat.vcxproj file was never updated with the last update, and whoever merged that updated didn't run appveyor (or they ignored the failure).

I'll send a PR to update the file. Looks like 3.6 got the change okay, so guessing it's just 3.5.

@zooba

zooba commented Sep 25, 2017

Copy link
Copy Markdown
Member

See #3751 for the fix.

@methane methane closed this Sep 25, 2017
@methane methane reopened this Sep 25, 2017
@larryhastings larryhastings merged commit 0fcc033 into python:3.5 Sep 26, 2017
@methane methane deleted the backport-a6296d3-3.5 branch December 19, 2017 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryhastings larryhastings Awaiting requested review from larryhastings

@zooba zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@methane @larryhastings @zooba @Mariatta @the-knights-who-say-ni @bedevere-bot