◐ Shell
reader mode source ↗
Skip to content

gh-56276: Add tests to test_compare#3199

Merged
terryjreedy merged 25 commits into
python:mainfrom
csabella:compare
May 20, 2023
Merged

gh-56276: Add tests to test_compare#3199
terryjreedy merged 25 commits into
python:mainfrom
csabella:compare

Conversation

@csabella

@csabella csabella commented Aug 24, 2017 •
edited by terryjreedy
Loading

Copy link
Copy Markdown
Contributor

The part of the Maier-Panter bpo patch that hasn't been committed yet (doc changes were).

Contributed by: Andy Maier.
Contributed by: Martin Panter.

@matrixise

matrixise commented Jan 30, 2018

Copy link
Copy Markdown
Member

Hello @csabella

What's the status of this PR?

Have a nice day

@csabella

csabella commented Jan 30, 2018

Copy link
Copy Markdown
Contributor Author

Hi @matrixise,

It hasn't been reviewed yet. I don't have any other updates.

This was referenced Jan 16, 2022
Closed
Closed
Closed
Closed
@terryjreedy
From test_compare part of PR-15167. …
8811145 
From test_compare part of PR-15167.
@terryjreedy

terryjreedy commented Jan 26, 2022

Copy link
Copy Markdown
Member

Merge conflicts were from test_compare part of #15167. Waiting for retest results.

On issue, Martin Panter said, after committing doc changes, "Someone needs to decide whether to use Andy’s tests as they are, or perhaps modify or drop some or all of them." Cheryl created this PR from the test part of the last .diff file and review is still needed.

@terryjreedy

terryjreedy commented Jan 26, 2022

Copy link
Copy Markdown
Member

Tests that I presume once passed now fail due to improved constant constant folding and identity checking of results. The following now prints True & True in batch mode, whereas the tests below presume the opposite. (In interactive mode, where each line is compiled separately, they print false as matching constants requires that they be compiled together.) I think all the is not tests should be deleted. Only leave 'a is a' test and 'a is not b' where b is bound to a different constant.

test_binary_sequences (test.test_compare.ComparisonFullTest) ... FAIL
test_numbers (test.test_compare.ComparisonFullTest) ... FAIL
test_sequences (test.test_compare.ComparisonFullTest) ... FAIL

======================================================================
FAIL: test_binary_sequences (test.test_compare.ComparisonFullTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_compare.py", line 642, in test_binary_sequences
    self.assertIsNot(bs2, bs3, "Testcase error: bs2 is bs3")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: unexpectedly identical: b'b2' : Testcase error: bs2 is bs3

======================================================================
FAIL: test_numbers (test.test_compare.ComparisonFullTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_compare.py", line 516, in test_numbers
    self.assertIsNot(c2, c3, "Testcase error: c2 is c3")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: unexpectedly identical: (2+2j) : Testcase error: c2 is c3

======================================================================
FAIL: test_sequences (test.test_compare.ComparisonFullTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_compare.py", line 604, in test_sequences
    self.assertIsNot(t2, t3, "Testcase error: t2 is t3")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: unexpectedly identical: (2, 3) : Testcase error: t2 is t3

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 26, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 29, 2022
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 30, 2022
@arhadthedev arhadthedev changed the title bpo-12067: Add tests to test_compare Apr 18, 2023
@arhadthedev

arhadthedev commented Apr 18, 2023

Copy link
Copy Markdown
Member

Retriggering the latest test suit so everyone concerned has access to the failed logs.

19 hidden items Load more…
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 20, 2023
@terryjreedy terryjreedy mentioned this pull request May 20, 2023
Closed
terryjreedy and others added 3 commits May 20, 2023 11:09
@terryjreedy @arhadthedev
Update Lib/test/test_compare.py …
8447237 
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@terryjreedy @arhadthedev
Update Lib/test/test_compare.py …
75e445d 
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@terryjreedy
Merge branch 'main' into compare
699befa
@terryjreedy terryjreedy merged commit 68ee8b3 into python:main May 20, 2023
@miss-islington

miss-islington commented May 20, 2023

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 20, 2023

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented May 20, 2023

Copy link
Copy Markdown

GH-104694 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 20, 2023
@python python deleted a comment from miss-islington May 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2023
@csabella @terryjreedy
@arhadthedev @miss-islington
pythongh-56276: Add tests to test_compare (pythonGH-3199) …
5583900 
(cherry picked from commit 68ee8b3)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
terryjreedy added a commit that referenced this pull request May 20, 2023
@miss-islington @csabella
@terryjreedy @arhadthedev
[3.11] gh-56276: Add tests to test_compare (GH-3199) (#104694) …
795b20e 
gh-56276: Add tests to test_compare (GH-3199)
(cherry picked from commit 68ee8b3)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@terryjreedy terryjreedy terryjreedy left review comments

Assignees

@terryjreedy terryjreedy

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@csabella @matrixise @terryjreedy @arhadthedev @miss-islington @bedevere-bot @the-knights-who-say-ni @ezio-melotti