bpo-29576: Improve some deprecations in the importlib#32
Conversation
8cc3e57 to
58d8d3c
Compare
February 12, 2017 19:46
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 82.37% 82.36% -0.01%
==========================================
Files 1427 1427
Lines 350948 350951 +3
==========================================
- Hits 289093 289062 -31
- Misses 61855 61889 +34Continue to review full report at Codecov.
|
Sorry, something went wrong.
brettcannon
left a comment
There was a problem hiding this comment.
Could you add tests to make sure the warnings are being raised?
Sorry, something went wrong.
Add the python version since the functionality is deprecated, and raise a couple of deprecation warnings in a few places. Theses functions are marked as deprecated in the documentation, but especially in existing codebase, programmers tends to not re-check whether functions are deprecated. So trigger the warning when possible. It's also more probable that a developer will drop deprecated functionality if we immediately give them information about replacement API, and not have them to go find it in the documentation. Include deprecation information in DocString as well as many tools pull documentation from there and not from docs.python.org. Add test making sure `find_loader()` and `find_module()` Both emit a deprecation warning.
58d8d3c to
51e8898
Compare
February 15, 2017 20:11
|
All comments should be addressed. |
Sorry, something went wrong.
|
Thanks! Please add entries in Misc/NEWS and one in What's New in the "deprecated" section and this will be ready to be merged! |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
|
Thanks ! |
Sorry, something went wrong.
Add the python version since the functionality is deprecated,
and raise a couple of deprecation warnings in a few places.
Theses functions are marked as deprecated in the documentation, but
especially in existing codebase, programmers tends to not re-check
whether functions are deprecated. So trigger the warning when possible.
It's also more probable that a developer will drop deprecated
functionality if we immediately give them information about
replacement API, and not have them to go find it in the documentation.
Include deprecation information in DocString as well, as many tools pull
documentation from there and not from docs.python.org.