{{ message }}
bpo-47000: Add locale.getencoding()#32068
Merged
methane merged 13 commits intoApr 9, 2022
Merged
Conversation
Member
Sorry, something went wrong.
methane
force-pushed
the
locale-get-encoding
branch
from
c99ef77 to
8fc120e
Compare
March 31, 2022 06:13
methane
force-pushed
the
locale-get-encoding
branch
from
04fd5b0 to
8b50eb1
Compare
April 4, 2022 03:16
methane
force-pushed
the
locale-get-encoding
branch
from
ffc9ba1 to
a0204c2
Compare
April 4, 2022 04:58
vstinner
reviewed
Apr 6, 2022
vstinner
reviewed
Apr 6, 2022
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
In some places, "utf-8" is used, in some other places "UTF-8" is used. I suggest to use lower case "utf-8" everywhere: doc, C code, _Py_STR(), etc. You may have to update getpreferredencoding() doc.
Sorry, something went wrong.
Co-authored-by: Victor Stinner <vstinner@python.org>
methane
force-pushed
the
locale-get-encoding
branch
from
39e99bc to
7720b10
Compare
April 7, 2022 04:18
vstinner
reviewed
Apr 7, 2022
vstinner
approved these changes
Apr 8, 2022
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks.
IMO it's important that the current is complete and explains well this function, since it's a complex topic. If the doc is unclear, people will misuse it.
Thanks for adding "See also the filesystem encoding and error handler" in the glossary, that's good!
I'm not sure why the PR is still a draft.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This API is a part of PEP 686.
https://bugs.python.org/issue47000