◐ Shell
reader mode source ↗
Skip to content

bpo-4833: Add ZipFile.mkdir#32160

Merged
ethanfurman merged 8 commits into
python:mainfrom
dignissimus:bpo-1590744
Apr 5, 2022
Merged

bpo-4833: Add ZipFile.mkdir#32160
ethanfurman merged 8 commits into
python:mainfrom
dignissimus:bpo-1590744

Conversation

@dignissimus

@dignissimus dignissimus commented Mar 28, 2022 •
edited by merwok
Loading

Copy link
Copy Markdown
Contributor

Add ZipFile.mkdir method to create directories inside zip archives.

https://bugs.python.org/issue4833

ethanfurman
ethanfurman reviewed Mar 28, 2022
View reviewed changes

@ethanfurman ethanfurman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Very thorough PR. Question in-line.

@dholth

dholth commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

interesting, since it is also possible to imply directories (if there is a file in there) but this would allow an empty directory

@ethanfurman

ethanfurman commented Mar 31, 2022

Copy link
Copy Markdown
Member

@dignissimus : ping me in a few days if no one has merged this yet -- I want to give other folks the chance to review.

@ethanfurman

ethanfurman commented Mar 31, 2022

Copy link
Copy Markdown
Member

@dignissimus Actually, I forgot: have you either verified or added a test for creating a directory using the existing write() method? (Yes, it should work -- nevertheless, a test is good).

@dignissimus

dignissimus commented Apr 1, 2022

Copy link
Copy Markdown
Contributor Author

@dignissimus Actually, I forgot: have you either verified or added a test for creating a directory using the existing write() method? (Yes, it should work -- nevertheless, a test is good).

@ethanfurman The tests have been added!

@merwok merwok changed the title bpo-4833: Adds ZipFile.mkdir Apr 1, 2022
@dignissimus

dignissimus commented Apr 5, 2022

Copy link
Copy Markdown
Contributor Author

@ethanfurman

@bedevere-bot bedevere-bot added and removed awaiting review labels Apr 5, 2022
@ethanfurman ethanfurman merged commit 050a8f9 into python:main Apr 5, 2022
@JelleZijlstra JelleZijlstra mentioned this pull request May 2, 2022
Merged
@schuppenies schuppenies mannequin mentioned this pull request Apr 10, 2022
Closed
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dignissimus @dholth @ethanfurman @merwok @the-knights-who-say-ni @bedevere-bot