{{ message }}
bpo-46841: Use a bytes object for _co_code_adaptive#32205
Merged
markshannon merged 2 commits intoApr 1, 2022
Merged
Conversation
Member
Sorry, something went wrong.
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The
memoryviewwas a fun idea, but it actually creates some subtle memory management issues (since it can possibly outlive the code object it references).While we could fix this by hacking around inside of the returned
memoryviewor giving code objects full buffer protocol support, abytesobject is totally fine here (and it even makes disassembly a bit easier).https://bugs.python.org/issue46841