gh-91389: Fix show_caches in dis module#32406
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
brandtbucher
left a comment
There was a problem hiding this comment.
Thanks! A few notes:
- Please sign the CLA (you've probably seen the bot's message by now).
- This needs a NEWS entry. Something simple like "
Fix an issue where passing ``show_caches=True`` to :mod:`dis` utilities could result in incorrect position information." should be fine. - It also needs at least one regression test in
Lib/test/test_dis.pythat fails before this change and passes after. - You can also add your name to
Misc/ACKS, if you want. 😎
Let me know if you have any questions.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
I have made the requested changes; please review again |
Sorry, something went wrong.
|
Thanks for making the requested changes! @brandtbucher: please review the changes made to this pull request. |
Sorry, something went wrong.
|
Please don't merge. I want to improve the unit test. |
Sorry, something went wrong.
963afcc to
3fd5c3e
Compare
April 8, 2022 19:35
|
I changed the unit test. What do you think @brandtbucher ? |
Sorry, something went wrong.
brandtbucher
left a comment
There was a problem hiding this comment.
Almost there... just a couple of naming/formatting improvements:
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
3fd5c3e to
82e0ecb
Compare
April 14, 2022 07:22
|
The following commit authors need to sign the Contributor License Agreement: |
Sorry, something went wrong.
|
I have made the requested changes; please review again |
Sorry, something went wrong.
|
Thanks for making the requested changes! @brandtbucher: please review the changes made to this pull request. |
Sorry, something went wrong.
|
@15r10nk, can you re-sign the CLA using your polarbit.de address? If the CLA bot doesn't let you, please add this email to your Github emails in settings. If you click on the list of commits in this PR now, you will see that the author of the commit is listed as "Frank Hoffmann" and doesn't link back to your profile. |
Sorry, something went wrong.
|
Yes, I will do, unfortunately not before next week Wednesday. |
Sorry, something went wrong.
|
It seems that I was to late :-). |
Sorry, something went wrong.
https://bugs.python.org/issue47233