◐ Shell
reader mode source ↗
Skip to content

bpo-31337 Close a minor NULL dereference opportunity#3282

Closed
warsaw wants to merge 5 commits into
python:masterfrom
warsaw:compile-null-ptr
Closed

bpo-31337 Close a minor NULL dereference opportunity#3282
warsaw wants to merge 5 commits into
python:masterfrom
warsaw:compile-null-ptr

Conversation

@warsaw

@warsaw warsaw commented Sep 4, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@warsaw warsaw changed the title Close a minor NULL dereference opportunity Sep 4, 2017
@serhiy-storchaka

serhiy-storchaka commented Sep 5, 2017 via email

Copy link
Copy Markdown
Member

@warsaw

warsaw commented Sep 5, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

@serhiy-storchaka Oh, I see what your reference to "Victor's runtime checks" are. Yes, I knew about the !PyErr_Occurred() check, but not the reference.

I don't agree that this is obviously dead code. You have to reason about the control flow, and assume that -DNDEBUG was not given, and that nothing changes to subtle break the assumptions in this code. With additional feedback, I am however willing to forego applying this in favor of a more comprehensive fix for bpo-31338.

@warsaw

warsaw commented Sep 6, 2017

Copy link
Copy Markdown
Member Author

Closing this in favor of bpo-33138

@warsaw warsaw closed this Sep 6, 2017
@warsaw warsaw deleted the compile-null-ptr branch September 6, 2017 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@warsaw @serhiy-storchaka @Mariatta @the-knights-who-say-ni @bedevere-bot