◐ Shell
reader mode source ↗
Skip to content

bpo-30860: Consolidate stateful runtime globals.#3397

Merged
ericsnowcurrently merged 94 commits into
python:masterfrom
ericsnowcurrently:interp-globals
Sep 8, 2017
Merged

bpo-30860: Consolidate stateful runtime globals.#3397
ericsnowcurrently merged 94 commits into
python:masterfrom
ericsnowcurrently:interp-globals

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Sep 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

(trying again; see #2594)

  • group the (stateful) runtime globals into various topical structs
  • consolidate the topical structs under a single top-level _PyRuntimeState struct
  • add a check-c-globals.py script that helps identify runtime globals

Other globals are excluded (see globals.txt and check-c-globals.py).

https://bugs.python.org/issue30860

@ericsnowcurrently ericsnowcurrently requested a review from a team September 6, 2017 22:31
@bedevere-bot bedevere-bot added the label Sep 6, 2017
@ericsnowcurrently
Add the check-c-globals script.
d4799a7
@ericsnowcurrently
Clean up the check-c-globals script.
9abaa7b
@ericsnowcurrently
Update the list of "runtime" globals.
aa3a7db
@ericsnowcurrently
Handle builtin modules via a pattern check.
c7c86c7
@ericsnowcurrently
Rely on a pattern check for static type-related vars.
6b991d9
@ericsnowcurrently
Handle most exceptions and warnings via pattern checks.
8a8763d
@ericsnowcurrently
Clean up _is_type_var().
c8b5b43
@ericsnowcurrently
Add runtime vars for builtin modules.
72e1d9b
@ericsnowcurrently
Ignore trailing comments in globals-runtime.txt.
f51e788
@ericsnowcurrently
Add runtime vars for builtin types.
9836224
@ericsnowcurrently
Add runtime vars for compiler.
9dab7a7
@ericsnowcurrently
Add runtime vars for interpreter.
7e1cad8
@ericsnowcurrently
Add runtime vars for import.
7b8279a
@ericsnowcurrently
Add runtime vars for startup.
c067341
@ericsnowcurrently
Add other runtime vars.
794fb24
@ericsnowcurrently
Separate the 3 runtime global "scopes".
942dbfa
@ericsnowcurrently
Do not worry about a possible race.
7a2c42a
@ericsnowcurrently
Narrow down the globals lists.
2e6526b
@ericsnowcurrently
runtime -> core.
39296ea
@ericsnowcurrently
Hold up more globals.
103205d
@ericsnowcurrently
Add _PyRuntimeState and _PyRuntime.
ea3a2cf
@ericsnowcurrently
Pull pylifecycle globals into _PyRuntimeState.
a112d71
64 hidden items Load more…
@ericsnowcurrently ericsnowcurrently requested a review from a team as a code owner September 8, 2017 01:17
@ericsnowcurrently ericsnowcurrently merged commit 2ebc5ce into python:master Sep 8, 2017
@ericsnowcurrently ericsnowcurrently mentioned this pull request Sep 8, 2017
Merged
ma8ma added a commit to ma8ma/cpython that referenced this pull request Sep 9, 2017
@ma8ma
Merge branch 'master' into pep539-tss-api …
414b07d 
Resolve conflicts:
2ebc5ce bpo-30860: Consolidate stateful runtime globals. (python#3397)
ericsnowcurrently added a commit that referenced this pull request Sep 12, 2017
@ericsnowcurrently
bpo-30860: Move windows.h include out of internal/*.h. (#3458) …
fc1bf87 
PR #3397 introduced a large number of warnings to the Windows build. This patch fixes them.
@Mariatta Mariatta removed the label Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp left review comments

@ncoghlan ncoghlan ncoghlan approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ericsnowcurrently @benjaminp @ncoghlan @Mariatta @the-knights-who-say-ni @bedevere-bot