◐ Shell
reader mode source ↗
Skip to content

bpo-31344: Per-frame control of trace events#3417

Merged
ncoghlan merged 7 commits into
python:masterfrom
ncoghlan:bpo-31344-per-opcode-trace-events
Sep 8, 2017
Merged

bpo-31344: Per-frame control of trace events#3417
ncoghlan merged 7 commits into
python:masterfrom
ncoghlan:bpo-31344-per-opcode-trace-events

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

f_trace_lines: enable/disable line trace events
f_trace_opcodes: enable/disable opcode trace events

These are intended primarily for testing of the interpreter
itself, as they make it much easier to emulate signals
arriving at unfortunate times.

https://bugs.python.org/issue31344

@zooba

zooba commented Sep 7, 2017

Copy link
Copy Markdown
Member

Ping @int19h - any thoughts? :)

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good to me (with a post-8pm caveat)

@int19h

int19h commented Sep 7, 2017

Copy link
Copy Markdown

This would potentially come in handy for debuggers; e.g. we could implement per-statement (rather than per-line) stepping with this.

f_trace_lines: enable/disable line trace events
f_trace_opcodes: enable/disable opcode trace events

These are intended primarily for testing of the interpreter
itself, as they make it much easier to emulate signals
arriving at unfortunate times.
@ncoghlan ncoghlan force-pushed the bpo-31344-per-opcode-trace-events branch from 494f6e7 to 8c9fcba Compare September 7, 2017 17:14

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

overall good, some comments to address.

@ncoghlan

ncoghlan commented Sep 8, 2017

Copy link
Copy Markdown
Contributor Author

Merging as the previous Appveyor run already passed: https://ci.appveyor.com/project/python/cpython/build/3.7.0a0.6126

@ncoghlan ncoghlan merged commit 5a85167 into python:master Sep 8, 2017
@ncoghlan ncoghlan deleted the bpo-31344-per-opcode-trace-events branch March 30, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants