◐ Shell
reader mode source ↗
Skip to content

Fix stderr bug in json.tool test#346

Merged
berkerpeksag merged 1 commit into
python:masterfrom
dhimmel:pipe-bug
Mar 15, 2017
Merged

Fix stderr bug in json.tool test#346
berkerpeksag merged 1 commit into
python:masterfrom
dhimmel:pipe-bug

Conversation

@dhimmel

@dhimmel dhimmel commented Feb 27, 2017

Copy link
Copy Markdown
Contributor

This was referenced Feb 27, 2017
Merged
Closed
berkerpeksag
berkerpeksag reviewed Mar 1, 2017
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I just did a quick review and it looks good to me in general. I still need to test it locally.

@dhimmel

dhimmel commented Mar 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@berkerpeksag just wanted to check in on this PR. Would love to have it merged, since the two linked pull requests are dependent on it.

@dhimmel

dhimmel commented Mar 11, 2017

Copy link
Copy Markdown
Contributor Author

@mention-bot can you mention some relevant maintainers for this PR? I don't want progress to stall.

@berkerpeksag berkerpeksag merged commit b4e9087 into python:master Mar 15, 2017
@berkerpeksag

berkerpeksag commented Mar 15, 2017

Copy link
Copy Markdown
Member

Thanks! :)

berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Mar 15, 2017
@dhimmel @berkerpeksag
Fix stderr bug in json.tool test (python#346) …
072655f 
See python#201 (comment) picked from commit b4e9087)
@dhimmel dhimmel deleted the pipe-bug branch March 15, 2017 23:51
@dhimmel

dhimmel commented Mar 16, 2017

Copy link
Copy Markdown
Contributor Author

3.6 backport pull request is #676 (I guess GitHub doesn't automatically cross-reference issues in pull request titles).

berkerpeksag added a commit that referenced this pull request Mar 16, 2017
@berkerpeksag
Fix stderr bug in json.tool test (#346) (#676) …
0dfd18a 
See #201 (comment) picked from commit b4e9087)
@dhimmel dhimmel mentioned this pull request Jul 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhimmel @berkerpeksag @the-knights-who-say-ni