gh-63075: IDLE editor - Auto insertion of the closers#3520
Conversation
Sorry, something went wrong.
adds fg color, bg color, font, and underline options for parens highlighting
How did the change to the __doc__ of append not get fixed in the tests earlier?
Used incorrect / old python for testing.
per terryjreedy request.
Fixing code conflict ate highlighting options. Needed to be re-introduced.
…eight as non-core keybinding test example.
idleConf expects a string bool, not type bool. whoops.
In use, it was irritating for me to have both perform the action. This way, users can pick one or both or none.
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Now that we are no longer implementing new features as extensions, this patch needs to be rewritten before it can be properly review in action. If someone else wants to do so before I get to it, please say so in a comment.
The comments below indicate the major changes needed.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
Trigger a retest to see if CI produces same odd failures as on another PR.
|
I would like to help out, but I believe Charles would need to make the changes. I don't have 'push access' to his branch. |
Sorry, something went wrong.
|
Hi, Is it possible to somehow include this patch manually, after installation of Python, even if it's not fully worked-on here? |
Sorry, something went wrong.
|
This PR makes a unrelated changes to the unix file mode of Tools/ssl/multissltests.py. This must be reverted between this can be applied. I don't think I can do so in Windows. Clicking ... to the right gives an option to 'Delete file'. I have the impression that this actually adds file deletion to the PR rather than removing the file change from the PR. |
Sorry, something went wrong.
|
There is no patch to the IDLE doc. I now think that this perhaps even be the first thing to do, rather than a possibly delayed afterthought. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
github-actions
Bot
removed
the
stale
Stale PR or inactive for long period of time.
label
Jul 29, 2022
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
terryjreedy
changed the title
github-actions
Bot
removed
the
stale
Stale PR or inactive for long period of time.
label
Aug 31, 2022
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
Reviewers
Assignees
6 participants
This patch is for Auto insertion of the closing parens, brackets, and braces enhancement. It includes necessary changes to config-extensions.def, and idlelib.test.test_config. It has its own test which covers all non - init statements. As of writing this, idlelib.tests passes on all tests other than calltips, which appears to be a preexisting problem.
https://bugs.python.org/issue18875