◐ Shell
reader mode source ↗
Skip to content

[3.6] bpo-31234: test_threaded_import: fix test_side_effect_import() (GH-3189)#3537

Merged
vstinner merged 1 commit into
python:3.6from
miss-islington:backport-41bbd82-3.6
Sep 13, 2017
Merged

[3.6] bpo-31234: test_threaded_import: fix test_side_effect_import() (GH-3189)#3537
vstinner merged 1 commit into
python:3.6from
miss-islington:backport-41bbd82-3.6

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 13, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • Don't leak the module into sys.modules
  • Avoid dangling thread
    (cherry picked from commit 41bbd82)

https://bugs.python.org/issue31234

@vstinner @miss-islington
[3.6] bpo-31234: test_threaded_import: fix test_side_effect_import() (p… …
5f899c4 
…ythonGH-3189)

* Don't leak the module into sys.modules
* Avoid dangling thread
(cherry picked from commit 41bbd82)
@bedevere-bot bedevere-bot mentioned this pull request Sep 13, 2017
Merged
@the-knights-who-say-ni

the-knights-who-say-ni commented Sep 13, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

vstinner
vstinner approved these changes Sep 13, 2017
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, good bot.

@vstinner vstinner merged commit 89bfc9b into python:3.6 Sep 13, 2017
@miss-islington

miss-islington commented Sep 13, 2017

Copy link
Copy Markdown
Contributor Author

Thanks, @Haypo!

@miss-islington miss-islington deleted the backport-41bbd82-3.6 branch September 13, 2017 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @the-knights-who-say-ni @vstinner @Mariatta @bedevere-bot