◐ Shell
reader mode source ↗
Skip to content

bpo-31170: Write unit test for Expat 2.2.4 UTF-8 bug#3570

Merged
vstinner merged 3 commits into
python:masterfrom
vstinner:expat224_utf8_bug
Sep 25, 2017
Merged

bpo-31170: Write unit test for Expat 2.2.4 UTF-8 bug#3570
vstinner merged 3 commits into
python:masterfrom
vstinner:expat224_utf8_bug

Conversation

@vstinner

@vstinner vstinner commented Sep 14, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@vstinner

vstinner commented Sep 14, 2017

Copy link
Copy Markdown
Member Author

The XML file comes from the libexpat bug: libexpat/libexpat#115

tiran
tiran approved these changes Sep 15, 2017
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I'm fine with using the reproducer from the expat bug.

@vstinner
bpo-31170: Write unit tests for Expat UTF-8 bug …
6c9efd1 
Non-regression tests for the Expat 2.2.3 UTF-8 decoder bug.
vstinner
vstinner commented Sep 16, 2017
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

New update to take latest @serhiy-storchaka comments in account.

@vstinner vstinner merged commit e6d9fcb into python:master Sep 25, 2017
@vstinner vstinner deleted the expat224_utf8_bug branch September 25, 2017 08:27
@vstinner

vstinner commented Sep 25, 2017

Copy link
Copy Markdown
Member Author

Thanks for the review and advices @serhiy-storchaka!

@miss-islington

miss-islington commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

1 similar comment
@miss-islington

miss-islington commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

Sorry, @Haypo, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e6d9fcbb8d0c325e57df08ae8781aafedb71eca2 2.7

@bedevere-bot

bedevere-bot commented Sep 25, 2017

Copy link
Copy Markdown

GH-3745 is a backport of this pull request to the 2.7 branch.

@bedevere-bot

bedevere-bot commented Sep 25, 2017

Copy link
Copy Markdown

GH-3746 is a backport of this pull request to the 3.6 branch.

vstinner added a commit that referenced this pull request Sep 25, 2017
@vstinner
bpo-31170: Write unit test for Expat 2.2.4 UTF-8 bug (#3570) (#3745) …
5f5da72 
Non-regression tests for the Expat 2.2.3 UTF-8 decoder bug.

(cherry picked from commit e6d9fcb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vstinner @miss-islington @bedevere-bot @tiran @serhiy-storchaka @Mariatta @the-knights-who-say-ni