◐ Shell
reader mode source ↗
Skip to content

bpo-30780: Add IDLE configdialog tests#3592

Merged
terryjreedy merged 11 commits into
python:masterfrom
csabella:bpo30780
Jan 27, 2020
Merged

bpo-30780: Add IDLE configdialog tests#3592
terryjreedy merged 11 commits into
python:masterfrom
csabella:bpo30780

Conversation

@csabella

@csabella csabella commented Sep 14, 2017 •
edited by terryjreedy
Loading

Copy link
Copy Markdown
Contributor

Expose dialog buttons to test code. Complete coverage for highlight and keys tabs
and for buttons and their functions.

https://bugs.python.org/issue30780

@terryjreedy terryjreedy self-assigned this May 20, 2018
@terryjreedy terryjreedy added tests Tests in the Lib/test dir needs backport to 3.7 labels May 20, 2018
@vstinner

vstinner commented Jan 10, 2019

Copy link
Copy Markdown
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@csabella csabella requested a review from terryjreedy as a code owner January 19, 2020 18:09
@csabella csabella mentioned this pull request Jan 25, 2020
Merged
@terryjreedy

terryjreedy commented Jan 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

I fixed the overt conflicts with the web editor. I fixed the failure on my local branch. I forgot that patch can only be used to temporarily replace existing attribute, not temporarily add new attribute. I intend to add context manager to idle_test.mock_idle for the latter, so we don't have to explicitly delete when instance is persistent across tests, as dialog is. I am now reviewing other tests and will add blurb and NEWS.txt items and update coverage when ready to commit.

@terryjreedy terryjreedy changed the title bpo-30780: IDLE: Complete keys and highlight coverage for configdialo… Jan 25, 2020
terryjreedy
terryjreedy reviewed Jan 26, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I still need to look at the new test_delete_custom_theme/keys code.

terryjreedy
terryjreedy approved these changes Jan 27, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Will merge when CI passes again.

@terryjreedy terryjreedy merged commit dd023ad into python:master Jan 27, 2020
20 hidden items Load more…
@bedevere-bot

bedevere-bot commented Jan 27, 2020

Copy link
Copy Markdown

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2020
@csabella @miss-islington
bpo-30780: Add IDLE configdialog tests (pythonGH-3592) …
fb97d52 
Expose dialog buttons to test code and complete their test coverage.
Complete test coverage for highlights and keys tabs.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit dd023ad)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

bedevere-bot commented Jan 27, 2020

Copy link
Copy Markdown

GH-18218 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jan 27, 2020

Copy link
Copy Markdown

GH-18219 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2020
@csabella @miss-islington
bpo-30780: Add IDLE configdialog tests (pythonGH-3592) …
7a93e89 
Expose dialog buttons to test code and complete their test coverage.
Complete test coverage for highlights and keys tabs.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit dd023ad)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Jan 27, 2020
@miss-islington @csabella
bpo-30780: Add IDLE configdialog tests (GH-3592) …
5aefee6 
Expose dialog buttons to test code and complete their test coverage.
Complete test coverage for highlights and keys tabs.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit dd023ad)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Jan 27, 2020
@miss-islington @csabella
bpo-30780: Add IDLE configdialog tests (GH-3592) …
7b57b15 
Expose dialog buttons to test code and complete their test coverage.
Complete test coverage for highlights and keys tabs.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit dd023ad)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the bpo30780 branch January 28, 2020 00:06
@csabella

csabella commented Jan 28, 2020

Copy link
Copy Markdown
Contributor Author

Terry, thanks for merging this! 🙂

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@csabella @terryjreedy @shihai1991
bpo-30780: Add IDLE configdialog tests (python#3592) …
755877e 
Expose dialog buttons to test code and complete their test coverage.
Complete test coverage for highlights and keys tabs.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy

Assignees

@terryjreedy terryjreedy

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csabella @vstinner @terryjreedy @bedevere-bot @miss-islington @the-knights-who-say-ni