bpo-31560: correct hashlib.blake2 keyed hashing example#3694
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Sorry, something went wrong.
|
Can you create an issue in the bug tracker for this, and the reference the issue number in the PR? |
Sorry, something went wrong.
|
@Mariatta done, thanks for pointing out the correct way to do it. (BTW, signed CLA submitted before submitting PR, it probably hasn't been reviewed yet.) Now, CI error: Should I replace it with some non-suspicions English name? ( |
Sorry, something went wrong.
dec1099 to
6514982
Compare
September 23, 2017 16:32
|
Replaced usernames with |
Sorry, something went wrong.
|
Thanks @dchest :) |
Sorry, something went wrong.
|
I don't recognize/understand that error message at all :-/ |
Sorry, something went wrong.
6514982 to
50dbd0c
Compare
September 23, 2017 16:43
|
Let's try to avoid it with |
Sorry, something went wrong.
|
Nope, still fails, but doesn't even show errors. Should I do this? Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv. If all issues are false positives, append that file to tools/susp-ignored.csv. |
Sorry, something went wrong.
|
I guess so!
…On Sat, Sep 23, 2017 at 12:50 PM, Dmitry Chestnykh ***@***.*** > wrote:
Nope, still fails, but doesn't even show errors. Should I do this?
Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv. If all issues are false positives, append that file to tools/susp-ignored.csv.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#3694 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAADBBHokWO4azXovNtD7IfTSSxFxMkIks5slTbMgaJpZM4Pgmgj>
.
--
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: D1B3 ADC0 E023 8CA6
|
Sorry, something went wrong.
|
I'll need some help there, as I don't quite sure what to include there.
But since the checker doesn't show what the problematic text is now, I'm not sure how to exclude it. |
Sorry, something went wrong.
|
The "error" is that the suspicious exceptions for hashlib no longer apply. You should simply remove them from |
Sorry, something went wrong.
50dbd0c to
c95fcb6
Compare
September 23, 2017 17:11
c95fcb6 to
b1c5ee1
Compare
September 23, 2017 17:14
|
Thanks @dchest for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Sorry, something went wrong.
|
Awesome, thank you! |
Sorry, something went wrong.
|
Thanks @dchest for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Sorry, something went wrong.
|
Sorry, @dchest and @benjaminp, I could not cleanly backport this to |
Sorry, something went wrong.
The example became broken when porting docs from pyblake2.
https://bugs.python.org/issue31560
https://bugs.python.org/issue31560