◐ Shell
reader mode source ↗
Skip to content

bpo-1294959 - better support for systems with /usr/lib64#3698

Closed
matejcik wants to merge 2 commits into
python:masterfrom
matejcik:build-64bit
Closed

bpo-1294959 - better support for systems with /usr/lib64#3698
matejcik wants to merge 2 commits into
python:masterfrom
matejcik:build-64bit

Conversation

@matejcik

@matejcik matejcik commented Sep 22, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This introduces a new configure and sysconfig variable platsubdir, which is the name of subdirectory of prefix that holds platform-specific libraries. On many Linux distributions, there is separation between /usr/lib and /usr/lib64, as opposed to prefix vs exec_prefix, which is what Python is accustomed to.

This should improve the situation, and platsubdir will be used to differentiate library subdirectories below prefix.

Based on last comments in the bug report http://bugs.python.org/issue1294959 , I have renamed "platlibdir" to "platsubdir" -- IMHO it's more important to note that this is platform-specific than that it is a library directory. (otherwise we'd end up with platlibsubdir and that's horrible ;) )

https://bugs.python.org/issue1294959

@matejcik

matejcik commented Sep 22, 2017

Copy link
Copy Markdown
Contributor Author

didn't add a NEWS entry because I don't know how to do it ... is there a script that generates the file names for the NEWS.d structure? Or can I just drop a file called "bpo-1294959.txt" there?

@stratakis

stratakis commented Sep 22, 2017

Copy link
Copy Markdown
Contributor

@matejcik You will have to use blurb for the NEWS entry: https://pypi.python.org/pypi/blurb

@hroncok

hroncok commented Sep 23, 2017

Copy link
Copy Markdown
Contributor

In Fedora, we patch Python to support lib64 as follows:

https://src.fedoraproject.org/rpms/python3/blob/master/f/00102-lib64.patch (only applied on 64bit builds)
https://src.fedoraproject.org/rpms/python3/blob/master/f/00205-make-libpl-respect-lib64.patch (always applied)

This is only a note, I haven't looked at this PR more closely just yet, I'll try to compare the patches as soon as I can, to see if this PR would enable us to drop both of them.

@hroncok

hroncok commented Sep 24, 2017

Copy link
Copy Markdown
Contributor

Apparently, replacing those 2 patches with this one builds and tests fine. https://koji.fedoraproject.org/koji/taskinfo?taskID=22047740

@matejcik

matejcik commented Oct 11, 2017

Copy link
Copy Markdown
Contributor Author

news entry added

@hroncok

hroncok commented Nov 28, 2017

Copy link
Copy Markdown
Contributor

What can we do to make this happen?

@encukou

encukou commented May 15, 2018

Copy link
Copy Markdown
Member

I am a core dev now and I can commit to pushing this through.
Please rebase and re-check on Fedora; I can then do the sanity check on Ubuntu that Matthias requested on the issue.
If this ever again becomes stuck on the CPython side, ping me directly.

grimreaper
grimreaper suggested changes May 16, 2018
View reviewed changes

@grimreaper grimreaper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

General comment: I wonder if it would make sense to make use of ax_set_default_paths_system.m4 as well

@vstinner

vstinner commented Jan 31, 2019

Copy link
Copy Markdown
Member

@matejcik: I'm now interested to review your PR, but first I would like to see conflicts resolved. Would you like to fix conflicts? Or do you prefer that I create a new PR based on your PR?

matejcik added 2 commits January 31, 2019 16:06
@matejcik
better support for systems with /usr/lib64 …
5799b9b 
This introduces a new configure and sysconfig variable `platsubdir`,
which is the name of subdirectory of $prefix that holds
platform-specific libraries. On many Linux distributions, there is
separation between /usr/lib and /usr/lib64, which was causing some
problems due to the way Python manages its install paths. Now, platsubdir
is used to select the appropriate lib directory.
@matejcik
acknowledge myself …
2a6e255 
news entry

news entry
@matejcik

matejcik commented Jan 31, 2019

Copy link
Copy Markdown
Contributor Author

@vstinner thanks, I fixed the basic conflicts.

Unfortunately, I see that the code (esp. in Modules/getpath.c) has drifted significantly, and this is no longer part of my day job. So I probably won't devote much time in getting this where it needs to go. Maybe @hroncok would be interested in taking over, or perhaps @mcepl ?

@hroncok

hroncok commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

Not me. I can help @vstinner get this done and tested in Fedora, but that's it, sorry.

@mcepl

mcepl commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

@matejcik @hroncok I hopefully will get to this later, but currently I struggle with fixing many packages failing on 3.7.*.

@stratakis

stratakis commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

I can start working on it, should be having some more time soon.

@stratakis stratakis mentioned this pull request Feb 4, 2019
Closed
@stratakis

stratakis commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

Opened #11755 in order to move this forward.

@brettcannon brettcannon added the type-feature A feature request or enhancement label Mar 29, 2019
@csabella

csabella commented May 23, 2019

Copy link
Copy Markdown
Contributor

Thank you to everyone for your work on this. I'm going to close this in favor of #11755 since that (at the time) was a rebase over master. If this one ends up being the better pull request to move the project forward, then this can be reopened.

@csabella csabella closed this May 23, 2019
@vstinner vstinner mentioned this pull request Feb 11, 2020
Merged
@vstinner

vstinner commented Feb 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

PR #11755 is an updated version of this PR. (EDIT: oops, I missed @stratakis's comment.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou

+2 more reviewers

@grimreaper grimreaper grimreaper requested changes

@hroncok hroncok hroncok left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review type-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.