◐ Shell
reader mode source ↗
Skip to content

bpo-31581: Reduce the number of imports for functools#3757

Merged
methane merged 7 commits into
python:masterfrom
methane:bpo31518-functools-import
Sep 30, 2017
Merged

bpo-31581: Reduce the number of imports for functools#3757
methane merged 7 commits into
python:masterfrom
methane:bpo31518-functools-import

Conversation

@methane

@methane methane commented Sep 26, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Since functools and collections are very commonly used, it's worth enough to optimize import.

https://bugs.python.org/issue31581

@methane

methane commented Sep 26, 2017

Copy link
Copy Markdown
Member Author

I added 'skip news' tag, since #1269 don't have news too.

ncoghlan
ncoghlan previously requested changes Sep 26, 2017
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The functools.singledispatch change seems reasonable to me, since the cost of checking the import cache twice will be cheap compared to the overhead of defining a new function to apply @singledispatch to.

As per the comments on the argparse PR, this should be accompanied by a comment explaining the trade-off (i.e. there are many programs that use functools without singledispatch, so we trade-off making singledispatch marginally slower for the benefit of making start-up of such applications slightly faster)

However, I'm less sure of the appropriateness of the start-up vs runtime cost trade-off for Counter.most_common, so I'd prefer to see that change in a separate PR.

@bedevere-bot

bedevere-bot commented Sep 26, 2017

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@methane methane force-pushed the bpo31518-functools-import branch from a0082b6 to f228a84 Compare September 26, 2017 08:47
@methane

methane commented Sep 28, 2017

Copy link
Copy Markdown
Member Author

However, I'm less sure of the appropriateness of the start-up vs runtime cost trade-off for Counter.most_common, so I'd prefer to see that change in a separate PR.

fixed.

@methane methane merged commit 9811e80 into python:master Sep 30, 2017
@methane methane deleted the bpo31518-functools-import branch September 30, 2017 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@ncoghlan ncoghlan ncoghlan left review comments

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@methane @bedevere-bot @ncoghlan @serhiy-storchaka @Mariatta @the-knights-who-say-ni