◐ Shell
reader mode source ↗
Skip to content

bpo-31641: Allow arbitrary iterables in concurrent.futures.as_completed()#3830

Merged
ambv merged 1 commit into
python:masterfrom
ambv:whyLenTho
Sep 29, 2017
Merged

bpo-31641: Allow arbitrary iterables in concurrent.futures.as_completed()#3830
ambv merged 1 commit into
python:masterfrom
ambv:whyLenTho

Conversation

@ambv

@ambv ambv commented Sep 29, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This was possible before. GH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now. This commit addresses this
problem.

https://bugs.python.org/issue31641

bpo-31641: Allow arbitrary iterables in `concurrent.futures.as_comple… …
768e810 
…ted()`

This was possible before.  pythonGH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now.  This commit addresses this
problem.
@ambv ambv added skip news needs backport to 3.6 type-bug An unexpected behavior, bug, or error labels Sep 29, 2017
@ambv

ambv commented Sep 29, 2017

Copy link
Copy Markdown
Contributor Author

News entry not required because this reverts a regression before a release was made.

@ambv ambv requested review from ned-deily and pitrou September 29, 2017 21:20
@ambv

ambv commented Sep 29, 2017

Copy link
Copy Markdown
Contributor Author

@ned-deily This is a release blocker for 3.6.3, please make sure to merge it. We'll probably want RC2 because of this?

pitrou
pitrou approved these changes Sep 29, 2017
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for noticing and for the quick fix!

@ambv ambv merged commit 574562c into python:master Sep 29, 2017
@miss-islington

miss-islington commented Sep 29, 2017

Copy link
Copy Markdown
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 29, 2017

Copy link
Copy Markdown

GH-3831 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2017
@ambv @miss-islington
[3.6] bpo-31641: Allow arbitrary iterables in `concurrent.futures.as_… …
0bb2c92 
…completed()` (pythonGH-3830)

This was possible before.  pythonGH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now.  This commit addresses this
problem.
(cherry picked from commit 574562c)
@ambv ambv deleted the whyLenTho branch September 29, 2017 21:34
ambv pushed a commit that referenced this pull request Sep 29, 2017
@miss-islington @ambv
[3.6] bpo-31641: Allow arbitrary iterables in `concurrent.futures.as_… …
9ef28b6 
…completed()` (GH-3830) (#3831)

This was possible before.  GH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now.  This commit addresses this
problem.
(cherry picked from commit 574562c)
ned-deily
ned-deily reviewed Sep 30, 2017
View reviewed changes

@ned-deily ned-deily left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@ned-deily

ned-deily commented Sep 30, 2017

Copy link
Copy Markdown
Member

Re: "We'll probably want [3.6.3] RC2 because of this?" We could and normally would but this change seems isolated enough and simple enough that, unless someone has a strong objection, I'm inclined to just cherry pick it into 3.6.3 final unless some other, more intrusive change comes along to trigger a second RC.

ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Oct 3, 2017
@miss-islington @ned-deily
[3.6] bpo-31641: Allow arbitrary iterables in `concurrent.futures.as_… …
2e3fd03 
…completed()` (pythonGH-3830) (python#3831)

This was possible before.  pythonGH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now.  This commit addresses this
problem.
(cherry picked from commit 574562c)
dalcinl added a commit to dalcinl/pythonfutures that referenced this pull request Oct 3, 2017
@dalcinl
Backport fixes to as_completed and map iterators (bpo-27144) …
61f5abb 
Python issues:

+ python/cpython#1560
+ python/cpython#3270
+ python/cpython#3830
@dalcinl dalcinl mentioned this pull request Oct 3, 2017
Merged
agronholm pushed a commit to agronholm/pythonfutures that referenced this pull request Nov 29, 2017
@dalcinl @agronholm
Backport fixes to as_completed and map iterators (bpo-27144) (#66) …
28fa404 
Python issues:

+ python/cpython#1560
+ python/cpython#3270
+ python/cpython#3830
@dependabot-preview dependabot-preview Bot mentioned this pull request May 17, 2018
Closed
@dependabot-preview dependabot-preview Bot mentioned this pull request Aug 15, 2018
Closed
@dependabot-preview dependabot-preview Bot mentioned this pull request Oct 11, 2018
Closed
@dependabot-preview dependabot-preview Bot mentioned this pull request Nov 6, 2018
Merged
This was referenced May 27, 2019
Closed
Open
@dependabot-preview dependabot-preview Bot mentioned this pull request Mar 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

skip news An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ambv @miss-islington @bedevere-bot @ned-deily @pitrou @Mariatta @the-knights-who-say-ni