◐ Shell
reader mode source ↗
Skip to content

bpo-21983: Fix a crash in ctypes.cast() in case the type argument is a ctypes structured data type.#3859

Merged
zooba merged 1 commit into
python:masterfrom
orenmn:bpo21983-fix-crash
May 9, 2018
Merged

bpo-21983: Fix a crash in ctypes.cast() in case the type argument is a ctypes structured data type.#3859
zooba merged 1 commit into
python:masterfrom
orenmn:bpo21983-fix-crash

Conversation

@orenmn

@orenmn orenmn commented Oct 2, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

In addition, add tests to test_ctypes to make sure that cast() raises a TypeError in case of a bad type argument (and doesn't crash).

https://bugs.python.org/issue21983

eric-wieser
eric-wieser approved these changes Feb 22, 2018
View reviewed changes

@eric-wieser eric-wieser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Fix looks obviously correct to me, and I can verify the test fails without it.

@zooba zooba merged commit d518d8b into python:master May 9, 2018
@miss-islington

miss-islington commented May 9, 2018

Copy link
Copy Markdown
Contributor

Thanks @orenmn for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 9, 2018

Copy link
Copy Markdown
Contributor

Thanks @orenmn for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 9, 2018

Copy link
Copy Markdown
Contributor

Thanks @orenmn for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2018
@orenmn @miss-islington
bpo-21983: Fix a crash in ctypes.cast() when passed a ctypes structur… …
2aff9b2 
…ed data type (pythonGH-3859)

(cherry picked from commit d518d8b)

Co-authored-by: Oren Milman <orenmn@gmail.com>
@bedevere-bot

bedevere-bot commented May 9, 2018

Copy link
Copy Markdown

GH-6745 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented May 9, 2018

Copy link
Copy Markdown
Contributor

Sorry, @orenmn and @zooba, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d518d8bc8d5dac1a1270612f424d33e0e5afc2b5 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2018
@orenmn @miss-islington
bpo-21983: Fix a crash in ctypes.cast() when passed a ctypes structur… …
c2cef08 
…ed data type (pythonGH-3859)

(cherry picked from commit d518d8b)

Co-authored-by: Oren Milman <orenmn@gmail.com>
@bedevere-bot

bedevere-bot commented May 9, 2018

Copy link
Copy Markdown

GH-6746 is a backport of this pull request to the 3.6 branch.

@eric-wieser

eric-wieser commented May 9, 2018

Copy link
Copy Markdown
Contributor

@orenmn: Any change you could take a look at #5576, since you've already been looking over ctypes?

miss-islington added a commit that referenced this pull request May 9, 2018
@miss-islington @orenmn
bpo-21983: Fix a crash in ctypes.cast() when passed a ctypes structur… …
8ac158a 
…ed data type (GH-3859)

(cherry picked from commit d518d8b)

Co-authored-by: Oren Milman <orenmn@gmail.com>
@orenmn

orenmn commented May 10, 2018

Copy link
Copy Markdown
Contributor Author

sorry Eric, but i am too busy nowadays...

miss-islington added a commit that referenced this pull request May 26, 2018
@miss-islington @orenmn
bpo-21983: Fix a crash in ctypes.cast() when passed a ctypes structur… …
e60f6e1 
…ed data type (GH-3859)

(cherry picked from commit d518d8b)

Co-authored-by: Oren Milman <orenmn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

+1 more reviewer

@eric-wieser eric-wieser eric-wieser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zooba zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@orenmn @miss-islington @bedevere-bot @eric-wieser @zooba @the-knights-who-say-ni