bpo-31715 Add mimetype for extension .mjs#3908
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Sorry, something went wrong.
|
The CLA has now been signed, is there anything blocking this? |
Sorry, something went wrong.
|
Needs review from @python/email-team and news entry. |
Sorry, something went wrong.
|
Thanks @Mariatta I've send @bmeck a PR that includes the news entry in bmeck@f54e12c Does it look like I did that correctly? |
Sorry, something went wrong.
|
@MylesBorins The news entry lgtm. If @bmeck ended up accepting your PR, then you should sign Python's CLA too. And we'll need to make sure to add |
Sorry, something went wrong.
update news
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Sorry, something went wrong.
|
CLA is confirmed if you want to re-run commit bot |
Sorry, something went wrong.
|
here's an example of this biting people in the wild https://twitter.com/kuvos/status/1046984084575150082 Anyway we could get review on this? |
Sorry, something went wrong.
|
I'll leave the argument to someone more familiar with RFC details on mimetypes (there are 3+ RFCs on this), but I think we should maintain consistency between our support of .js and .mjs files. Currently, .js files are @MylesBorins or @bmeck, do you see a reason to support |
Sorry, something went wrong.
|
@emilyemorehouse per the up to date HTML standard |
Sorry, something went wrong.
|
Sounds good, I'd make the argument that both should use |
Sorry, something went wrong.
|
I've opened #9678 and https://bugs.python.org/issue34875 to update the mimetype of |
Sorry, something went wrong.
…to fix-issue-31715
|
I have made the requested changes; please review again. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @asvetlov: please review the changes made to this pull request. |
Sorry, something went wrong.
|
@asvetlov: Please replace |
Sorry, something went wrong.
(cherry picked from 0854b92)
(chery picked from commit 0854b92)
(cherry picked from commit 0854b92)
(cherry picked from commit 0854b92)
…onGH-10977) (cherry picked from commit 0854b92)
see https://bugs.python.org/issue31715
https://bugs.python.org/issue31715