{{ message }}
bpo-31803: time.clock() now emits a DeprecationWarning#4020
Merged
vstinner merged 5 commits intoOct 17, 2017
Merged
Conversation
Member
Sorry, something went wrong.
bpo-31803: time.clock() and time.get_clock_info('clock') now emit a DeprecationWarning warning.
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Did you forgot to add a deprecation in get_clock_info('clock')?
Sorry, something went wrong.
Explicitly check that get_clock_info('clock') emits a
DeprecationWarning.
Remove also hasattr(time, 'monotonic') since time.monotonic() is now
always available since Python 3.5.
Member
Author
get_clock_info('clock') also emits a DeprecationWarning. I modified pyclock() which is used by time.clock() and time.get_clock_info('clock'). I just modified test_get_clock_info() to ensure that time.get_clock_info('clock') raises a warning, instead of ignoring the warning. |
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Oct 17, 2017
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
time.clock() and time.get_clock_info('clock') now emit a DeprecationWarning warning.
https://bugs.python.org/issue31803