{{ message }}
bpo-29271: Fix Task.current_task and Task.all_tasks to accept None.#406
Merged
1st1 merged 4 commits intoMar 3, 2017
Merged
Conversation
Member
Sorry, something went wrong.
|
@1st1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo, @methane and @serhiy-storchaka to be potential reviewers. |
Sorry, something went wrong.
Member
|
Aren't we usually appending news items instead of prepending?
Entries in Misc/NEWS should be prepended. Entries in What's New usually are
appended.
|
Sorry, something went wrong.
Member
Author
|
Thank you for helping out Serhiy. It's my first PRs to the new GH repo so I'm getting accustomed to some new practices. |
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Mar 2, 2017
Member
Author
|
@serhiy-storchaka BTW, to backport this to 3.6, do I need to create a new PR? Or I can just cherry-pick and push? |
Sorry, something went wrong.
Member
|
AFAIK you can't push directly into this repository. You need to create a new
PR. Add the label "need to backport to 3.6" to this PR and "cherry-pick for
3.6" to the new PR.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
See http://bugs.python.org/issue29271 for context. LGTM'ed by @methane