◐ Shell
reader mode source ↗
Skip to content

bpo-26228: pty.spawn hangs on FreeBSD, OS X, and Solaris#4167

Closed
diekmann wants to merge 7 commits into
python:mainfrom
diekmann:bpo-26228
Closed

bpo-26228: pty.spawn hangs on FreeBSD, OS X, and Solaris#4167
diekmann wants to merge 7 commits into
python:mainfrom
diekmann:bpo-26228

Conversation

@diekmann

@diekmann diekmann commented Oct 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

issue26228 as github PR.

This PR contains:

  • original patch of issue26228 by Chris
  • Update of docs
  • Update of pty test suite

According to the bpo discussion, this fixes pty.spawn() on FreeBSD, OS X, and Solaris.

https://bugs.python.org/issue26228

@diekmann diekmann changed the title Bpo 26228: pty.spawn hangs on FreeBSD, OS X, and Solaris Oct 29, 2017
@diekmann diekmann changed the title Bpo-26228: pty.spawn hangs on FreeBSD, OS X, and Solaris Oct 29, 2017
@diekmann diekmann mentioned this pull request Oct 29, 2017
Closed
vadmium
vadmium reviewed Nov 25, 2017
View reviewed changes

@vadmium vadmium left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I can’t see anything seriously wrong with 005dc23, although I think it would be better to test the API (pty.spawn), without depending on the internals (_copy, select, etc) if possible.

@diekmann

diekmann commented Dec 2, 2017

Copy link
Copy Markdown
Contributor Author

Yes, blackbox tests for the API (pty.spawn) would be nice. But at the moment, they could not be merged in isolation because they would fail on FreeBSD.
My idea:

  1. This pull request contains the minimum necessary changes to the existing tests, code, and doc to fix pty.spawn.
  2. Afterwards, in isolated (and hence easier to review) pull requests, more API tests for pty.spawn may follow. The test suite in bpo-29070: Integration tests for pty module with patch from bpo-26228 #2932 already has some. But bpo-29070: Integration tests for pty module with patch from bpo-26228 #2932 is just too huge to review and has too many unrelated changes.

@ambv

ambv commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

Closing in favor of GH-12049.

@ambv ambv closed this Aug 11, 2021
ambv added a commit to ambv/cpython that referenced this pull request Aug 13, 2021
@ambv @diekmann
bpo-26228: [doc] Adapt PTY documentation updates from pythonGH-4167 …
8d8a3b9 
Co-authored-by: Cornelius Diekmann <c.diekmann@googlemail.com>
@ambv

ambv commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

The doc part of this was included in GH-27754.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2021
@ambv @miss-islington
bpo-26228: [doc] Adapt PTY documentation updates from pythonGH-4167 (p… …
a0d7fe2 
…ythonGH-27754)

Co-authored-by: Cornelius Diekmann <c.diekmann@googlemail.com>
(cherry picked from commit dd8eb30)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Aug 13, 2021
@ambv @diekmann
bpo-26228: [doc] Adapt PTY documentation updates from GH-4167 (GH-27754) …
dd8eb30 
Co-authored-by: Cornelius Diekmann <c.diekmann@googlemail.com>
miss-islington added a commit that referenced this pull request Aug 13, 2021
@miss-islington @ambv
bpo-26228: [doc] Adapt PTY documentation updates from GH-4167 (GH-27754) …
d412848 
Co-authored-by: Cornelius Diekmann <c.diekmann@googlemail.com>
(cherry picked from commit dd8eb30)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadmium vadmium vadmium left review comments

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@diekmann @ambv @vadmium @the-knights-who-say-ni @bedevere-bot