◐ Shell
reader mode source ↗
Skip to content

bpo-31904 : Add support for VxWorks RTOS#4184

Closed
kuhlenough wants to merge 221 commits into
python:masterfrom
kuhlenough:master
Closed

bpo-31904 : Add support for VxWorks RTOS#4184
kuhlenough wants to merge 221 commits into
python:masterfrom
kuhlenough:master

Conversation

@kuhlenough

@kuhlenough kuhlenough commented Oct 31, 2017 •
edited
Loading

Copy link
Copy Markdown

This pull request enables cpython to cross-build on VxWorks, it is obsolete and only provided for reference of the scope of changes..
Smaller more manageable PRs against the current master as requested on python-dev will follow.

@kuhlenough
patch configure for VxWorks
10d4405
@kuhlenough
Any version of python should be OK for cross build.
9d53ef2
@kuhlenough
undef DATE TIME for VxWorks
db2e0e8
@kuhlenough
limited signal feilds in VxWorks
cb3aa97
@kuhlenough
bpo-31904 : Python should support VxWorks RTOS …
1939a13 
All doesn't include shared if static build
Hardwire asscii encoding for VxWorks
default to UTF-8 (like Android)
Semicolon as path separator
If build is configure'd for static, propigate to Makefile
Add detection for oddly named VxWorks OPENSSL and HASH libraries
Fix some warnings with unused functions and macro re-def
Extra include in faulthandler.c
Avoid duplicate macro definition
Setup.py complies all VxWorks compatible modules
Update some extension modules to compile on VxWorks
VxWorks does not have "timezone" and daylight "constants"
Limited signal fields in VxWorks
undef DATE TIME for VxWorks
@kuhlenough

kuhlenough commented Oct 31, 2017

Copy link
Copy Markdown
Author

Travis failures appear completely unrelated to this pull request?

220 hidden items Load more…
@gvanrossum

gvanrossum commented Apr 16, 2018

Copy link
Copy Markdown
Member

Yes, we'll clean this up the cruff and squash some commits.
I have no expectation that this pull will be merged until some discussion on long term support is agreed upon

Who is "we" here? Are you just a happy VxWorks user or are you working for the org or company that owns it (assume there is such an org or company)?

@kuhlenough
Revert "Update Doc build for split off of 3.7 branch" …
d0c89e4 
This reverts commit 7f38637.

# Conflicts:
#	Doc/tools/templates/indexsidebar.html
@terryjreedy terryjreedy removed their request for review April 16, 2018 21:55
@kuhlenough

kuhlenough commented Apr 16, 2018

Copy link
Copy Markdown
Author

Wind River owns VxWorks. ( https://www.windriver.com/products/vxworks/ It really is the most pervasive OS you've never heard of. ) I'm a manager at Wind River, as side project I contribute VxWorks support to open source projects. I work with the VxWorks Product Manager. The product manager, Michel, wants "official" python support. In reply to bpo-31904 bug/enhancement Victor (vstinner) mentioned we should have a buildbot to run against pull requests as part of any official support. So I hired an intern, Oscar @ooosssososos, to work on that. He's also been working on getting the test suite to pass with VxWorks. ( His work term ends soon, so we just merged his work into my branch and it seems we got some unwanted commits with that :( )

On my side I'd like to get some additional POSIX support into VxWorks, e.g. proper handling of fcntl( ,F_SETFD, FD_CLOEXEC) and that effort may take awhile.

@kuhlenough
Revert "Fix static linking extensions" …
d5127ac 
This reverts commit 18463dd.

# Conflicts:
#	Include/pystate.h
@kuhlenough
Revert "Fix Windows Build" …
d0ecc40 
This reverts commit 0ad214f.
@kuhlenough
Revert "Add more extensions to the test" …
43aeefc 
This reverts commit dd55e39.

# Conflicts:
#	Lib/test/test_support.py
@kuhlenough
revert linefeed changes
0b620c4
@kuhlenough
Revert "Fix static linking extensions" …
79f497a 
This reverts commit 18463dd.
@kuhlenough
clean-up cruff
cbcfdf9
@gpshead gpshead removed their request for review September 10, 2018 23:33
@nascheme

nascheme commented Jan 10, 2019

Copy link
Copy Markdown
Member

The code quality in this PR is pretty far from the standard needed to get merged into cpython. The number of changes needed to support VxWorks doesn't look too extreme. So, if we do want to support it, I think it can be done without too much pain. Probably we should decide if we are able to support the new platform before putting a lot of effort into polishing the code and getting it to the quality sufficient for merging.

@vstinner

vstinner commented Mar 27, 2019

Copy link
Copy Markdown
Member

This PR is just too big, it's not possible to review it. I close it.

You should continue the effort that you already started to split such giant PR into "atomic" changes for fix one issue per PR.

@vstinner vstinner closed this Mar 27, 2019
@kuhlenough

kuhlenough commented Mar 27, 2019

Copy link
Copy Markdown
Author

NP. thanks fro your support Victor

@kuhlenough kuhlenough mannequin mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@nascheme nascheme nascheme left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.