bpo-28180: Fix the implementation of PEP 538 on Android#4334
Conversation
|
Reminder: |
Sorry, something went wrong.
|
Is the "C.UTF-8" locale available on Android? |
Sorry, something went wrong.
|
Android has the "C.UTF-8" and "C" locales, see setlocale. |
Sorry, something went wrong.
ncoghlan
left a comment
There was a problem hiding this comment.
If I'm reading the code correctly, I think the outcome you're aiming for can be achieved more simply with one or two unconditional setenv calls.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
With the implementation of When one of the locale envt variable is set to 'C', 'POSIX' or an invalid locale, then locale coercion is done with the corresponding warnings printed as for the other *nix platforms, and this can be overriden with the envt variable |
Sorry, something went wrong.
|
I have made the requested changes; please review again. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @ncoghlan: please review the changes made to this pull request. |
Sorry, something went wrong.
ncoghlan
left a comment
There was a problem hiding this comment.
Nice, I like this approach to consolidating the platform dependent logic.
Sorry, something went wrong.
|
@xdegaye I'm wondering if we should actually add a short NEWS entry for this, though - that way there will be a clearer record as to when we consolidated the platform dependent handling of setting the locale from the environment, which should be useful for folks embedding CPython in larger applications. |
Sorry, something went wrong.
|
Closing and re-opening the PR because travis was hanged without starting. |
Sorry, something went wrong.
Ref: python/cpython#4334 pybuild-rebuild=ALL
https://bugs.python.org/issue28180