bpo-26187: Tests for sqlite3 trace callback#434
Conversation
|
@AnishShah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Yhg1s, @ghaering, @berkerpeksag, @mdickinson and @serhiy-storchaka to be potential reviewers. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Thanks, Aviv. Next time please send your feedback as a comment and give the PR author some time to address your comments. Otherwise, we will end up with duplicate PRs. Also note that we always locally run tests and make sure that the test fails before the fix is applied so the chance of merging a broken test is minimal. |
Sorry, something went wrong.
|
Sorry about that @berkerpeksag. I actually started by writing a comment on this PR but found out that what I do is to write the all test again. I am still having hard time understanding what @AnishShah did here as I wrote a test case in the issue. |
Sorry, something went wrong.
No description provided.