◐ Shell
reader mode source ↗
Skip to content

gh-76183: Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale#4361

Closed
embray wants to merge 1 commit into
python:mainfrom
embray:cygwin/test-c-locale-coercion
Closed

gh-76183: Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale#4361
embray wants to merge 1 commit into
python:mainfrom
embray:cygwin/test-c-locale-coercion

Conversation

@embray

@embray embray commented Nov 10, 2017 •
edited by erlend-aasland
Loading

Copy link
Copy Markdown
Contributor

Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale

@embray embray force-pushed the cygwin/test-c-locale-coercion branch from 91f7983 to 5f6d3a0 Compare November 10, 2017 11:17
@bedevere-bot

bedevere-bot commented Nov 11, 2017

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@embray embray mentioned this pull request Nov 13, 2017
Merged
@embray embray mentioned this pull request Apr 10, 2022
Closed
@github-actions

github-actions Bot commented Aug 13, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 13, 2022
@erlend-aasland

erlend-aasland commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

@embray: are you planning on following up this PR/issue?

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jan 24, 2023
@github-actions

github-actions Bot commented Feb 23, 2023

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 23, 2023
@erlend-aasland erlend-aasland changed the title bpo-32002 Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale Feb 23, 2023
@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Feb 23, 2023
@erlend-aasland

erlend-aasland commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

After one month, still no response. Suggesting to close this PR and the related issue (Cygwin is not supported).

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Feb 24, 2023
@arhadthedev

arhadthedev commented Mar 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@embray Could you address the reviews please?

@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 4, 2023
@erlend-aasland erlend-aasland removed the pending The issue will be closed if no feedback is provided label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan left review comments

+1 more reviewer

@xdegaye xdegaye xdegaye requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@embray @bedevere-bot @erlend-aasland @arhadthedev @ncoghlan @xdegaye @the-knights-who-say-ni @ezio-melotti