◐ Shell
reader mode source ↗
Skip to content

[3.8] bpo-10544: Disallow "yield" in comprehensions and generator expressions.#4564

Merged
serhiy-storchaka merged 8 commits into
python:masterfrom
serhiy-storchaka:disallow-yield-in-comprehencions
Feb 4, 2018
Merged

[3.8] bpo-10544: Disallow "yield" in comprehensions and generator expressions.#4564
serhiy-storchaka merged 8 commits into
python:masterfrom
serhiy-storchaka:disallow-yield-in-comprehencions

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 25, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka changed the title bpo-10544: Disallow "yield" in comprehensions and generator expressions. Nov 27, 2017
@serhiy-storchaka serhiy-storchaka force-pushed the disallow-yield-in-comprehencions branch from f4f684d to 6d5e555 Compare December 1, 2017 07:04
ncoghlan
ncoghlan requested changes Dec 1, 2017
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Just adding a blocking review to ensure we don't merge this until after the 3.7 maintenance branch has been created.

@bedevere-bot

bedevere-bot commented Dec 1, 2017

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@serhiy-storchaka

serhiy-storchaka commented Feb 3, 2018

Copy link
Copy Markdown
Member Author

Could you please look on this again Nick?

ncoghlan
ncoghlan approved these changes Feb 4, 2018
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, and the main branch is now open for 3.8 commits.

@serhiy-storchaka

serhiy-storchaka commented Feb 4, 2018

Copy link
Copy Markdown
Member Author

Maybe you can suggest better wording for What's New?

@ncoghlan

ncoghlan commented Feb 4, 2018

Copy link
Copy Markdown
Contributor

The What's New wording seemed fine to me.

@serhiy-storchaka serhiy-storchaka merged commit 07ca9af into python:master Feb 4, 2018
@serhiy-storchaka serhiy-storchaka deleted the disallow-yield-in-comprehencions branch February 4, 2018 08:53
@serhiy-storchaka

serhiy-storchaka commented Feb 4, 2018

Copy link
Copy Markdown
Member Author

Thank you @ncoghlan for your review.

@mjpieters mjpieters mentioned this pull request Feb 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @bedevere-bot @ncoghlan @the-knights-who-say-ni