◐ Shell
reader mode source ↗
Skip to content

bpo-10544: Deprecate "yield" in comprehensions and generator expressions.#4579

Merged
ncoghlan merged 14 commits into
python:masterfrom
serhiy-storchaka:deprecate-yield-in-comprehensions
Dec 1, 2017
Merged

bpo-10544: Deprecate "yield" in comprehensions and generator expressions.#4579
ncoghlan merged 14 commits into
python:masterfrom
serhiy-storchaka:deprecate-yield-in-comprehensions

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 27, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@ncoghlan

ncoghlan commented Nov 27, 2017

Copy link
Copy Markdown
Contributor

@serhiy-storchaka Do you mind if I just edit some of the docs wording directly? I think that will be easier than trying to describe the edits I would recommend.

@serhiy-storchaka

serhiy-storchaka commented Nov 27, 2017

Copy link
Copy Markdown
Member Author

I will be grateful if you do this.

@ncoghlan
Reword language reference updates …
bad2b05 
- updated the comprehension scoping definition to use
  some of the words from the generator expression definition
- added appropriate versionadded/changed directives
-
@ncoghlan
Fix typo in markup changes
109fd32
@ncoghlan
Reword What's New notice
e89b0c5
@ncoghlan
Reword NEWS entry
802a362
@ncoghlan
Describe specific consequences in What's New entry
5b9498d
@ncoghlan

ncoghlan commented Nov 27, 2017

Copy link
Copy Markdown
Contributor

OK, I've made my documentation edits.

@gvanrossum I think it would be helpful if you could review the proposed language reference updates directly, or else nominate someone else to do so.

gvanrossum
gvanrossum reviewed Nov 27, 2017
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Here are some suggestions to tighten the docs. Thanks to both of you for taking care of this!

@ncoghlan
Clarify eager evaluation of leftmost iterable …
5287acf 
- consistently use "leftmost" (never "outermost")
- explicitly exclude the filter condition from eager evaluation
- better align wording for comprehensions and generator expressions
@ncoghlan
Tweak What's New wording
adb6268
@gvanrossum

gvanrossum commented Nov 27, 2017

Copy link
Copy Markdown
Member

Docs LGTM now.

@serhiy-storchaka

serhiy-storchaka commented Nov 30, 2017

Copy link
Copy Markdown
Member Author

Ping.

@ncoghlan ncoghlan merged commit 73a7e9b into python:master Dec 1, 2017
@serhiy-storchaka serhiy-storchaka deleted the deprecate-yield-in-comprehensions branch December 1, 2017 06:23
@serhiy-storchaka

serhiy-storchaka commented Dec 1, 2017

Copy link
Copy Markdown
Member Author

Thank you for your documentation changes @ncoghlan!

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 2, 2017
@serhiy-storchaka
bpo-10544: Deprecate "yield" in comprehensions and generator expressi… …
b9d155c 
…ons in Py3k mode. (pythonGH-4579)
serhiy-storchaka added a commit that referenced this pull request Dec 2, 2017
@serhiy-storchaka
[2.7] bpo-10544: Deprecate "yield" in comprehensions and generator ex… …
65d1887 
…pressions in Py3k mode. (GH-4579) (#4676)
@serhiy-storchaka serhiy-storchaka mentioned this pull request Feb 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan left review comments

@gvanrossum gvanrossum gvanrossum left review comments

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @ncoghlan @gvanrossum @the-knights-who-say-ni @bedevere-bot