◐ Shell
reader mode source ↗
Skip to content

bpo-32165 Fix calling order of PyEval_InitThreads#4602

Merged
benjaminp merged 1 commit into
python:masterfrom
mrkn:order_of_init_threads
Sep 10, 2019
Merged

bpo-32165 Fix calling order of PyEval_InitThreads#4602
benjaminp merged 1 commit into
python:masterfrom
mrkn:order_of_init_threads

Conversation

@mrkn

@mrkn mrkn commented Nov 28, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

As described in Doc/c-api/init.rst, PyEval_InitThreads() cannot be called
before Py_Initialize() function.

https://bugs.python.org/issue32165

@mrkn
Fix calling order of PyEval_InitThreads …
d8e112c 
As described in Doc/c-api/init.rst, PyEval_InitThreads() cannot be called
before Py_Initialize() function.
@the-knights-who-say-ni

the-knights-who-say-ni commented Nov 28, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@mrkn

mrkn commented Nov 28, 2017

Copy link
Copy Markdown
Contributor Author

I've signed the CLA.

@mrkn mrkn changed the title Fix calling order of PyEval_InitThreads Nov 29, 2017
@benjaminp benjaminp closed this Sep 10, 2019
@benjaminp benjaminp reopened this Sep 10, 2019
@benjaminp benjaminp merged commit 9e61066 into python:master Sep 10, 2019
@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Thanks @mrkn for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@mrkn @miss-islington
Fix calling order of PyEval_InitThreads. (pythonGH-4602) …
4117d35 
As described in Doc/c-api/init.rst, PyEval_InitThreads() cannot be called
before Py_Initialize() function.
(cherry picked from commit 9e61066)

Co-authored-by: Kenta Murata <mrkn@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15832 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15833 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@mrkn @miss-islington
Fix calling order of PyEval_InitThreads. (pythonGH-4602) …
3a501fb 
As described in Doc/c-api/init.rst, PyEval_InitThreads() cannot be called
before Py_Initialize() function.
(cherry picked from commit 9e61066)

Co-authored-by: Kenta Murata <mrkn@users.noreply.github.com>
@mrkn mrkn deleted the order_of_init_threads branch September 10, 2019 10:35
@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Thanks @mrkn for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@mrkn @miss-islington
Fix calling order of PyEval_InitThreads. (pythonGH-4602) …
d962901 
As described in Doc/c-api/init.rst, PyEval_InitThreads() cannot be called
before Py_Initialize() function.
(cherry picked from commit 9e61066)

Co-authored-by: Kenta Murata <mrkn@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15836 is a backport of this pull request to the 3.8 branch.

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@mrkn @websurfer5
Fix calling order of PyEval_InitThreads. (pythonGH-4602) …
eca0f80 
As described in Doc/c-api/init.rst, PyEval_InitThreads() cannot be called
before Py_Initialize() function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mrkn @the-knights-who-say-ni @miss-islington @bedevere-bot @benjaminp @Mariatta