◐ Shell
reader mode source ↗
Skip to content

bpo-32101: Add PYTHONDEVMODE environment variable#4624

Merged
vstinner merged 4 commits into
python:masterfrom
vstinner:pythondevmode
Nov 30, 2017
Merged

bpo-32101: Add PYTHONDEVMODE environment variable#4624
vstinner merged 4 commits into
python:masterfrom
vstinner:pythondevmode

Conversation

@vstinner

@vstinner vstinner commented Nov 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Add also the sys.flags.dev_mode flag.

https://bugs.python.org/issue32101

@vstinner vstinner requested a review from pitrou November 29, 2017 00:03
@vstinner vstinner requested a review from 1st1 as a code owner November 29, 2017 00:03
@bedevere-bot bedevere-bot added the label Nov 29, 2017
@vstinner vstinner changed the title bpo-321010: Add PYTHONDEVMODE environment variable Nov 29, 2017
@vstinner

vstinner commented Nov 29, 2017

Copy link
Copy Markdown
Member Author

Oh, test_sys fails in development mode, but it's unrelated to this PR: bug fixed by PR #4625.

Another bug: test_faulthandler and test_asyncio now fail with PYTHONDEVMODE=1.

@vstinner
bpo-32101: Add sys.flags.dev_mode flag …
4c3e538 
Rename also the "Developer mode" to the "Development mode".
@vstinner
bpo-32101: Add PYTHONDEVMODE environment variable …
0eb6e7d 
Mention it in the development chapiter.
@vstinner

vstinner commented Nov 29, 2017

Copy link
Copy Markdown
Member Author

I rebased my change to get the memory allocator fixes (commit 5d39e04), and I documented the "Python development mode" in the Development chapiter of the documentation.

@vstinner

vstinner commented Nov 29, 2017

Copy link
Copy Markdown
Member Author

Ok, the patch now works properly, and the full Python test suite pass with PYTHONDEVMODE=1.

@ncoghlan, @pitrou: What do you think of adding sys.flags.dev_mode?

I chose to make sys.flags.dev_mode a boolean, whereas other flags are integer and have a Py_xxx variable in C.

ncoghlan
ncoghlan approved these changes Nov 30, 2017
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good to me. I'm OK with the idea of committing to dev mode being an "all or nothing" toggle - the more fine-grained control already exists in the form of the underlying settings that dev mode groups together.

@vstinner vstinner merged commit 5e3806f into python:master Nov 30, 2017
@vstinner vstinner deleted the pythondevmode branch November 30, 2017 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@pitrou pitrou Awaiting requested review from pitrou

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @ncoghlan @the-knights-who-say-ni @bedevere-bot