◐ Shell
reader mode source ↗
Skip to content

[2.7] bpo-10544: Deprecate "yield" in comprehensions and generator expressions in Py3k mode. (GH-4579)#4676

Merged
serhiy-storchaka merged 3 commits into
python:2.7from
serhiy-storchaka:deprecate-yield-in-comprehensions-2.7
Dec 2, 2017
Merged

[2.7] bpo-10544: Deprecate "yield" in comprehensions and generator expressions in Py3k mode. (GH-4579)#4676
serhiy-storchaka merged 3 commits into
python:2.7from
serhiy-storchaka:deprecate-yield-in-comprehensions-2.7

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 2, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

They will be deprecated in Python 3.7 and prohibited in Python 3.8.

https://bugs.python.org/issue10544

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Dec 2, 2017
@bedevere-bot bedevere-bot added the type-feature A feature request or enhancement label Dec 2, 2017
ncoghlan
ncoghlan approved these changes Dec 2, 2017
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This looks good to me, just one request for an explanatory comment on the new list comp checking code.

@serhiy-storchaka serhiy-storchaka merged commit 65d1887 into python:2.7 Dec 2, 2017
@serhiy-storchaka serhiy-storchaka deleted the deprecate-yield-in-comprehensions-2.7 branch December 2, 2017 19:00
@serhiy-storchaka

serhiy-storchaka commented Dec 2, 2017

Copy link
Copy Markdown
Member Author

Thanks @ncoghlan!

@mjpieters

mjpieters commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

This is on the 2.7 branch, not the 3.7 branch. In 3.7b1 this is currently not a deprecation warning. Wrong branch perhaps?

@serhiy-storchaka

serhiy-storchaka commented Feb 6, 2018

Copy link
Copy Markdown
Member Author

See #4579 for 3.7 and #4676 for 3.8.

@mjpieters

mjpieters commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

Excellent, thanks! I was confused because I missed that 3.7 was still the master branch when the first commit went in, the separate 3.7 branch had yet to be cut.

See #4579 for 3.7 and #4676 for 3.8.

<mode demeanor="pedant">#4676 is this PR :-) The 3.8 SyntaxError change is #4564.</mode>

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @mjpieters @ncoghlan @the-knights-who-say-ni @bedevere-bot