◐ Shell
reader mode source ↗
Skip to content

bpo-32199: uuid.getnode() now returns the MAC address on Android#4696

Merged
xdegaye merged 3 commits into
python:masterfrom
xdegaye:bpo-32199
Dec 7, 2017
Merged

bpo-32199: uuid.getnode() now returns the MAC address on Android#4696
xdegaye merged 3 commits into
python:masterfrom
xdegaye:bpo-32199

Conversation

@xdegaye

@xdegaye xdegaye commented Dec 4, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@xdegaye xdegaye added the type-bug An unexpected behavior, bug, or error label Dec 4, 2017
@bedevere-bot

bedevere-bot commented Dec 4, 2017

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@xdegaye

xdegaye commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Dec 7, 2017

Copy link
Copy Markdown

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

@xdegaye xdegaye merged commit 961dbe0 into python:master Dec 7, 2017
@miss-islington

miss-islington commented Dec 7, 2017

Copy link
Copy Markdown
Contributor

Thanks @xdegaye for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the label Dec 7, 2017
@xdegaye xdegaye deleted the bpo-32199 branch December 7, 2017 11:59
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 7, 2017
@xdegaye @miss-islington
bpo-32199: The getnode() ip getter now uses 'ip link' instead of 'ip … …
b5d356c 
…link list' (pythonGH-4696)

(cherry picked from commit 961dbe0)
@bedevere-bot

bedevere-bot commented Dec 7, 2017

Copy link
Copy Markdown

GH-4747 is a backport of this pull request to the 3.6 branch.

xdegaye pushed a commit that referenced this pull request Dec 7, 2017
@miss-islington @xdegaye
bpo-32199: The getnode() ip getter now uses 'ip link' instead of 'ip … …
03031fb 
…link list' (GH-4696) (#4747)

(cherry picked from commit 961dbe0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw requested changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xdegaye @bedevere-bot @miss-islington @warsaw @serhiy-storchaka @the-knights-who-say-ni