◐ Shell
reader mode source ↗
Skip to content

Add Guido and Ivan as owners for typing.py#4729

Merged
ned-deily merged 2 commits into
masterfrom
typing-owners
Dec 5, 2017
Merged

Add Guido and Ivan as owners for typing.py#4729
ned-deily merged 2 commits into
masterfrom
typing-owners

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Dec 5, 2017

Copy link
Copy Markdown
Member

@ned-deily ned-deily merged commit 5e8cbcc into master Dec 5, 2017
@ned-deily ned-deily deleted the typing-owners branch December 5, 2017 21:56
@miss-islington

miss-islington commented Dec 5, 2017

Copy link
Copy Markdown
Contributor

Thanks @gvanrossum for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Dec 5, 2017

Copy link
Copy Markdown
Contributor

Sorry, @gvanrossum and @ned-deily, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5e8cbcc4f25dcdc02651414f792dc4a546ba199b 3.6

@Mariatta

Mariatta commented Dec 5, 2017

Copy link
Copy Markdown
Member

Codeowners is only in master branch. Do we need it in the other branches?

@gvanrossum

gvanrossum commented Dec 5, 2017

Copy link
Copy Markdown
Member Author

Let's not.

@ned-deily

ned-deily commented Dec 5, 2017

Copy link
Copy Markdown
Member

Having it only with master is fine with me, I didn't realize it was only there. So no backport needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gvanrossum @miss-islington @Mariatta @ned-deily @ilevkivskyi @the-knights-who-say-ni @bedevere-bot