◐ Shell
reader mode source ↗
Skip to content

bpo-32225: Implementation of PEP 562#4731

Merged
ilevkivskyi merged 13 commits into
python:masterfrom
ilevkivskyi:module-getattr
Dec 14, 2017
Merged

bpo-32225: Implementation of PEP 562#4731
ilevkivskyi merged 13 commits into
python:masterfrom
ilevkivskyi:module-getattr

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Dec 5, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This is a basic implementation of the PEP. Suggestions are welcome.

@gvanrossum @serhiy-storchaka Can one of you (or both?) please review?

https://bugs.python.org/issue32225

@ilevkivskyi ilevkivskyi changed the title [skip-issue] [skip-news] Implementation of PEP 562 Dec 5, 2017
@ilevkivskyi ilevkivskyi changed the title [skip-news] bpo-32225: Implementation of PEP 562 Dec 5, 2017
serhiy-storchaka
serhiy-storchaka reviewed Dec 5, 2017
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Add a What's New entry and document this feature in corresponding places.

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Dec 5, 2017
@ilevkivskyi

ilevkivskyi commented Dec 8, 2017

Copy link
Copy Markdown
Member Author

@serhiy-storchaka @merwok is something left to do here?

@csabella

csabella commented Dec 10, 2017

Copy link
Copy Markdown
Contributor

@ilevkivskyi Nick made a comment on the ticket about adding documentation. @serhiy-storchaka and @merwok would need to let you know if anything else was needed.

@serhiy-storchaka

serhiy-storchaka commented Dec 10, 2017

Copy link
Copy Markdown
Member

The documentation is required. @ncoghlan given a good suggestion.

@ilevkivskyi

ilevkivskyi commented Dec 10, 2017

Copy link
Copy Markdown
Member Author

OK, I added docs as proposed by @ncoghlan (I also mentioned __class__).

@ilevkivskyi ilevkivskyi mentioned this pull request Dec 10, 2017
Merged
@serhiy-storchaka

serhiy-storchaka commented Dec 10, 2017

Copy link
Copy Markdown
Member

And please document PEP 562 in the What's New document.

serhiy-storchaka
serhiy-storchaka approved these changes Dec 10, 2017
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. But perhaps @ncoghlan has other suggestions about the documentation.

Thanks, this is a nice improvement.

@ncoghlan

ncoghlan commented Dec 14, 2017 via email

Copy link
Copy Markdown
Contributor

@ilevkivskyi

ilevkivskyi commented Dec 14, 2017

Copy link
Copy Markdown
Member Author

+1 to merging from me

OK, then I am going to merge this now.

@ilevkivskyi ilevkivskyi merged commit 5364b5c into python:master Dec 14, 2017
@ilevkivskyi ilevkivskyi deleted the module-getattr branch December 14, 2017 10:59
@gvanrossum

gvanrossum commented Dec 14, 2017 via email

Copy link
Copy Markdown
Member

@skirpichev skirpichev mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@csabella csabella csabella left review comments

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ilevkivskyi @csabella @serhiy-storchaka @ncoghlan @gvanrossum @merwok @the-knights-who-say-ni @bedevere-bot