bpo-13553: Document tkinter.Tk args#4786
Conversation
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
None of my comments are outdated by applying Serhiy's suggestions. My review just happened to start before the patch arrived, and except for 1, happen to be attached to the same sentences. Serhiy, please also review my comments. |
Sorry, something went wrong.
|
I have made the requested changes; please review again. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
Sorry, something went wrong.
|
@terryjreedy @serhiy-storchaka @vstinner |
Sorry, something went wrong.
|
I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
Sorry, something went wrong.
|
@csabella Looks like this PR is almost OK, maybe just missing the mention that |
Sorry, something went wrong.
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good, it seems the remaining comments don't need to be blocking.
Sorry, something went wrong.
|
Planning to merge this unless someone has further comments. |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
Thanks @csabella for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11. |
Sorry, something went wrong.
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
https://bugs.python.org/issue13553