bpo-30256: pass all BaseProxy arguments through AutoProxy#4819
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Sorry, something went wrong.
|
I signed the CLA (over a month ago) and my bpo account reflects that, however @the-knights-who-say-ni has not updated yet. |
Sorry, something went wrong.
|
When will this get merged ? |
Sorry, something went wrong.
|
I stumbled upon this problem, too: https://stackoverflow.com/questions/56716470/python-multiprocessing-nested-shared-objects-doesnt-work-with-queue Right now, Python docs state
These changes have been introduced with https://hg.python.org/cpython/rev/39e7307f9aee along with some tests. However, the tests only use nested So maybe this PR should add tests for Update: Some tests have been added with #16341 |
Sorry, something went wrong.
|
@uSpike could you add an entry to Misc/News.d/next for this issue? maybe it get merged when CI is fine |
Sorry, something went wrong.
|
Hey I just want to say that this patch fixed my issue. |
Sorry, something went wrong.
|
@pitrou, care to review? It looks like there's at least one PR waiting on this. I'm not too familiar with |
Sorry, something went wrong.
aacc4ba to
2cc5894
Compare
September 25, 2019 18:56
Sorry, something went wrong.
|
Any update on this one? Feels like a very easy fix :) @applio around for a quick approval? |
Sorry, something went wrong.
Sorry, something went wrong.
|
Gentle bump? This PR has been open for 2.5 years, it's a trivial change, and I'd love to be a contributor! I really don't want to miss the window for 3.9. |
Sorry, something went wrong.
There was a problem hiding this comment.
Update : I was wondering it a test exists and I saw the test here : #16341 sorry.
Sorry, something went wrong.
|
When testing this fix, this post on StackOverflow suggests they experienced a seg fault: https://stackoverflow.com/questions/56716470/multiprocessing-manager-nested-shared-objects-doesnt-work-with-queue Has this been investigated and resolved? |
Sorry, something went wrong.
|
I was not able to reproduce any seg faults with this patch |
Sorry, something went wrong.
|
I tried this patch and I did not get any segfaults. Would be nice if this could get fixed into python 3.9. My system: |
Sorry, something went wrong.
|
I'm also unable to reproduce any seg faults in 3.7.5 on Ubuntu 20.04. I may be wrong, but I think the stackoverflow message that @applio is referencing is not suggesting that this patch causes a seg fault. The code he says "works" is the same as this patch. |
Sorry, something went wrong.
The AutoProxy method did not accept the "manager_owned" keyword argument which broke when nested AutoProxy objects were created.
https://bugs.python.org/issue30256