◐ Shell
reader mode source ↗
Skip to content

bpo-15873: add '.fromisoformat' for date, time and datetime#4841

Closed
deronnax wants to merge 1 commit into
python:masterfrom
deronnax:bpo_15873_parse_iso_datetime
Closed

bpo-15873: add '.fromisoformat' for date, time and datetime#4841
deronnax wants to merge 1 commit into
python:masterfrom
deronnax:bpo_15873_parse_iso_datetime

Conversation

@deronnax

@deronnax deronnax commented Dec 13, 2017

Copy link
Copy Markdown
Contributor

adding method 'fromisoformat' to date, time and datetime classes

https://bugs.python.org/issue15873

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@SylvainDe SylvainDe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

It looks mostly good to me. I've added a few comments which may or may not be relevant.

@abalkin

abalkin commented Mar 1, 2018

Copy link
Copy Markdown
Member

Closing since an alternative implementation has been merged. See GH-4699.

@abalkin abalkin closed this Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants