◐ Shell
reader mode source ↗
Skip to content

bpo-30416: Protect the optimizer during constant folding.#4860

Merged
serhiy-storchaka merged 5 commits into
python:masterfrom
serhiy-storchaka:safe-const-folding
Dec 15, 2017
Merged

bpo-30416: Protect the optimizer during constant folding.#4860
serhiy-storchaka merged 5 commits into
python:masterfrom
serhiy-storchaka:safe-const-folding

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 14, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

It no longer spends much time doing complex calculations and no longer consumes much memory for creating large constants that will be dropped later.

This fixes also bpo-21074.

https://bugs.python.org/issue30416

@serhiy-storchaka
bpo-30416: Protect the optimizer during constant folding. …
68f097d 
It no longer spends much time doing complex calculations and no
longer consumes much memory for creating large constants that will
be dropped later.

This fixes also bpo-21074.
methane
methane approved these changes Dec 14, 2017
View reviewed changes

@methane methane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

vstinner
vstinner reviewed Dec 14, 2017
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you @serhiy-storchaka for working on this! A few comments.

@vstinner

vstinner commented Dec 14, 2017

Copy link
Copy Markdown
Member

Ok for 1024 items, but why limiting a single tuple to 256? Maybe 1024 should be used for all limits?

@serhiy-storchaka

serhiy-storchaka commented Dec 14, 2017

Copy link
Copy Markdown
Member Author

Oh, it already is increased from 20 to 256. I think this is enough.

@serhiy-storchaka serhiy-storchaka merged commit 2e3f570 into python:master Dec 15, 2017
@serhiy-storchaka serhiy-storchaka deleted the safe-const-folding branch December 15, 2017 12:11
@WolframAlph WolframAlph mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@methane methane methane approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @vstinner @methane @the-knights-who-say-ni @bedevere-bot