◐ Shell
reader mode source ↗
Skip to content

bpo-32030: Update sys.path[0] earlier for main importer#4868

Closed
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:path0
Closed

bpo-32030: Update sys.path[0] earlier for main importer#4868
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:path0

Conversation

@vstinner

@vstinner vstinner commented Dec 14, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@vstinner

vstinner commented Dec 14, 2017

Copy link
Copy Markdown
Member Author

See also https://bugs.python.org/issue32324 which is related (but not directly) to modified code.

@vstinner

vstinner commented Dec 14, 2017

Copy link
Copy Markdown
Member Author

Side effect of this change: sys.path is now modified before "import readline" when main_importer_path is set.

@vstinner

vstinner commented Dec 14, 2017

Copy link
Copy Markdown
Member Author

Side effect of this change: sys.path is now modified before "import readline" when main_importer_path is set.

Note: in such case, readline is only imported if the -i option is used.

@vstinner

vstinner commented Dec 14, 2017

Copy link
Copy Markdown
Member Author

I'm not sure that this change is correct. I don't understand well of sys.path is used to run the "main" module. Again, see https://bugs.python.org/issue32324

@vstinner vstinner closed this Feb 1, 2018
@vstinner vstinner deleted the path0 branch May 29, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot