◐ Shell
reader mode source ↗
Skip to content

bpo-32360: Remove OrderedDict reference as dicts are ordered now#4994

Merged
methane merged 2 commits into
python:masterfrom
srinivasreddy:32360
Jan 24, 2018
Merged

bpo-32360: Remove OrderedDict reference as dicts are ordered now#4994
methane merged 2 commits into
python:masterfrom
srinivasreddy:32360

Conversation

@srinivasreddy

@srinivasreddy srinivasreddy commented Dec 23, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@srinivasreddy

srinivasreddy commented Jan 2, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@asvetlov Just a question. Tagging someone who can review and merge is fine here? If so, could you please look into this PR? 😄

methane
methane requested changes Jan 18, 2018
View reviewed changes

@methane methane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Why don't you use collections.Counter instead?

@bedevere-bot

bedevere-bot commented Jan 18, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@srinivasreddy

srinivasreddy commented Jan 23, 2018

Copy link
Copy Markdown
Contributor Author

@methane Done. Thanks for the review.

@srinivasreddy

srinivasreddy commented Jan 24, 2018

Copy link
Copy Markdown
Contributor Author

@methane Please add skip-news label too.!!

@methane methane merged commit 018e1b7 into python:master Jan 24, 2018
@srinivasreddy srinivasreddy deleted the 32360 branch January 24, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@methane methane methane approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srinivasreddy @bedevere-bot @methane @merwok @the-knights-who-say-ni