{{ message }}
bpo-32360: Replace OrderedDict with dict in inspect.py module#5000
Closed
srinivasreddy wants to merge 2 commits into
Closed
bpo-32360: Replace OrderedDict with dict in inspect.py module#5000srinivasreddy wants to merge 2 commits into
srinivasreddy wants to merge 2 commits into
Conversation
Contributor
Sorry, something went wrong.
srinivasreddy
changed the title
merwok
reviewed
Dec 23, 2017
merwok
reviewed
Jan 24, 2018
merwok
reviewed
Jan 24, 2018
merwok
reviewed
Jan 24, 2018
Member
|
I did not mean to ask to remove one line in your patch (the import OrderedDict, which in your latest version is an unused import). I meant that the whole PR seems in the end not needed, since we end up importing collections anyway, and using OrderedDict makes for clearer code. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue32360