{{ message }}
bpo-32411: IDLE: Remove line number sort in browser.py#5011
Merged
terryjreedy merged 3 commits intoJun 1, 2019
Merged
Conversation
Contributor
Sorry, something went wrong.
Member
|
ON HOLD, as explained on the issue. |
Sorry, something went wrong.
terryjreedy
added
performance
Performance or resource usage
needs backport to 3.7
labels
May 20, 2018
terryjreedy
requested changes
May 20, 2018
terryjreedy
left a comment
terryjreedy
left a comment
Member
There was a problem hiding this comment.
The requested 'change' is to wait for circumstances to change ;-).
Sorry, something went wrong.
Contributor
|
LGTM. |
Sorry, something went wrong.
terryjreedy
changed the title
terryjreedy
approved these changes
Jun 1, 2019
|
@terryjreedy: Please replace |
Sorry, something went wrong.
Contributor
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 1, 2019
Insertion in line order makes sorting keys by line order unneeded. (cherry picked from commit 1a4d9ff) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jun 1, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Insertion in line order makes sorting keys by line order unneeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Since the input dictionary is created in line number and dictionaries are guaranteed to be in insertion order, the sort is no longer needed.
https://bugs.python.org/issue32411