bpo-10381: Add timezone to datetime C API#5032
Conversation
fa54439 to
09377f2
Compare
December 28, 2017 20:23
|
I added documentation for the macros, but I didn't see an obvious place to document that the |
Sorry, something went wrong.
e85cfc9 to
70fe5a2
Compare
January 5, 2018 17:34
|
@pganssle - IIRC, my comment on the issue was about PyDateTime_TimeZone struct which should probably stay private and not exposed in the header file. Your PR does the right thing in this regard. |
Sorry, something went wrong.
abalkin
left a comment
There was a problem hiding this comment.
Please remove the "Check" methods and limit this PR to TimeZone_UTC and constructors.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
70fe5a2 to
d026f56
Compare
January 12, 2018 14:26
|
@abalkin Ready for review. I added a new commit rather than rewriting the history, because I figure it might be useful to have access to the tests and such later if this is ever exposed. |
Sorry, something went wrong.
fb1b06c to
c38ea33
Compare
January 16, 2018 21:37
c38ea33 to
70642af
Compare
January 20, 2018 17:42
This adds C API access to
timezoneand thetimezone.UTCsingleton, per bpo-10381.@abalkin I didn't totally understand what you meant by "I am not sure whether PyDateTime_TimeZone details should be exposed in datetime.h because presumably programmers should access it through the abstract tzinfo interface.", so please clarify if this PR is exposing the details you referred to.
https://bugs.python.org/issue10381