◐ Shell
reader mode source ↗
Skip to content

Add 2018#5069

Closed
m1guelpf wants to merge 4 commits into
python:masterfrom
m1guelpf-forks:patch-2
Closed

Add 2018#5069
m1guelpf wants to merge 4 commits into
python:masterfrom
m1guelpf-forks:patch-2

Conversation

@m1guelpf

@m1guelpf m1guelpf commented Jan 1, 2018 •
edited
Loading

Copy link
Copy Markdown

TO DO:

  • Wait to the next year (100% done)
  • Merge!

:octocat:

@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 1, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@nzec

nzec commented Jan 1, 2018

Copy link
Copy Markdown

@m1guelpf Signing the PSF Contributor Agreement is required for contributing to Python.

@m1guelpf

m1guelpf commented Jan 1, 2018

Copy link
Copy Markdown
Author

@the-knights-who-say-ni @duttaditya18 Signed!

timgraham
timgraham reviewed Jan 1, 2018
View reviewed changes

@timgraham timgraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

There are more places to update based on last year's commit: e527dd3.

@timgraham timgraham mentioned this pull request Jan 2, 2018
Merged
2 tasks
@nzec

nzec commented Jan 3, 2018 •
edited
Loading

Copy link
Copy Markdown

@m1guelpf I would suggest you to squash the commits.

And also update the dates in Doc/license.rst, Mac/PythonLauncher/Info.plist.in, Mac/Resources/app/Info.plist.in, Mac/Resources/framework/Info.plist.in, PC/python_nt.rc, Python/getcopyright.c and README

@asvetlov

asvetlov commented Jan 3, 2018

Copy link
Copy Markdown
Contributor

@duttaditya18 Pull Request is squashed on merging anyway.

@nzec

nzec commented Jan 3, 2018

Copy link
Copy Markdown

@asvetlov Oh yeah! Forgot that!

@m1guelpf m1guelpf requested a review from a team as a code owner January 3, 2018 19:11
@m1guelpf

m1guelpf commented Jan 3, 2018

Copy link
Copy Markdown
Author

@duttaditya18 Done!

@nzec

nzec commented Jan 4, 2018

Copy link
Copy Markdown

@m1guelpf Awesome!!

@nzec

nzec commented Jan 4, 2018

Copy link
Copy Markdown

@m1guelpf Awesome! Now wait for the merger!

@asvetlov

asvetlov commented Jan 5, 2018

Copy link
Copy Markdown
Contributor

Done by @benjaminp in #5094 #5104 #5105

@asvetlov asvetlov closed this Jan 5, 2018
@nzec

nzec commented Jan 5, 2018

Copy link
Copy Markdown

@m1guelpf Dang dude! Couldn't get your contribution to Python. Keep trying though.

@m1guelpf m1guelpf deleted the patch-2 branch January 5, 2018 18:21
@hugovk hugovk mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@timgraham timgraham timgraham left review comments

@rooterkyberian rooterkyberian rooterkyberian requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@m1guelpf @the-knights-who-say-ni @nzec @asvetlov @timgraham @rooterkyberian @zware @bedevere-bot