◐ Shell
reader mode source ↗
Skip to content

bpo-32549: Compile OpenSSL 1.1.0 on Travis CI#5180

Merged
tiran merged 1 commit into
python:masterfrom
tiran:travis_openssl
Jan 16, 2018
Merged

bpo-32549: Compile OpenSSL 1.1.0 on Travis CI#5180
tiran merged 1 commit into
python:masterfrom
tiran:travis_openssl

Conversation

@tiran

@tiran tiran commented Jan 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Use an improved version of multissl test helper to compile a local copy
of OpenSSL 1.1.0g.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue32549

@tiran tiran force-pushed the travis_openssl branch 2 times, most recently from 31cac11 to 0857d9c Compare January 14, 2018 10:42
@tiran tiran changed the title Compile OpenSSL 1.1.0 for Travis CI Jan 14, 2018
@tiran tiran force-pushed the travis_openssl branch 2 times, most recently from 1a2dc69 to 88ae122 Compare January 14, 2018 10:51
@tiran
bpo-32549: Compile OpenSSL 1.1.0 on Travis CI …
b35b7ff 
Use an improved version of multissl test helper to compile a local copy
of OpenSSL 1.1.0g.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran requested review from brettcannon and vstinner January 16, 2018 15:36
@tiran

tiran commented Jan 16, 2018

Copy link
Copy Markdown
Member Author

@brettcannon @vstinner

This PR is a prerequisite for several of my ssl improvements. Do you agree with my approach? I'm going to remove the hak ss soon as Travis has OpenSSL 1.0.2+ in a base image.

Also see travis-ci/travis-ci#9069

@tiran tiran mentioned this pull request Jan 16, 2018
Merged
brettcannon
brettcannon approved these changes Jan 16, 2018
View reviewed changes

@brettcannon brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM; whatever works to unblock you is basically fine by me. 😄

@tiran

tiran commented Jan 16, 2018

Copy link
Copy Markdown
Member Author

@brettcannon thanks! I'm also changing travis CI settings from monthly to daily cron job on master. This will populate the cache tonight. Further runs should reuse pre-cached openssl builds.

@tiran tiran merged commit ced9cb5 into python:master Jan 16, 2018
@tiran tiran deleted the travis_openssl branch January 16, 2018 20:02
@tiran

tiran commented Jan 16, 2018

Copy link
Copy Markdown
Member Author

s/change/add/g

We didn't have cronjob runs at all. I misunderstood the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments

@brettcannon brettcannon brettcannon approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran @brettcannon @pitrou @the-knights-who-say-ni @bedevere-bot