◐ Shell
reader mode source ↗
Skip to content

bpo-29176: Fix name of the _curses.window class#52

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:curses_fix_window_class_name
Feb 12, 2017
Merged

bpo-29176: Fix name of the _curses.window class#52
vstinner merged 1 commit into
python:masterfrom
vstinner:curses_fix_window_class_name

Conversation

@vstinner

@vstinner vstinner commented Feb 12, 2017

Copy link
Copy Markdown
Member

Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).

@vstinner
bpo-29176: Fix name of the _curses.window class …
6f49906 
Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).
@codecov

codecov Bot commented Feb 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #52 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   82.37%   82.37%   +<.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
+ Hits       289093   289098       +5     
+ Misses      61855    61850       -5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22bfaa...6f49906. Read the comment docs.

briancurtin
briancurtin reviewed Feb 12, 2017
View reviewed changes

@briancurtin briancurtin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

+1, trivial change

briancurtin
briancurtin approved these changes Feb 12, 2017
View reviewed changes

@briancurtin briancurtin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

+1, trivial change (actually approving now)

@vstinner

vstinner commented Feb 12, 2017

Copy link
Copy Markdown
Member Author

Serhiy Storshaka asked me if the change can have any impact on pickle. No, it doesn't because these objects were not picklable before and are not pickable after ;-)
http://bugs.python.org/issue29176#msg287521

@vstinner vstinner merged commit 61e2bc7 into python:master Feb 12, 2017
Mariatta referenced this pull request in Mariatta/cpython Mar 7, 2017
@vstinner @Mariatta
bpo-29176: Fix name of the _curses.window class (#52) …
51c864c 
Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).
(cherry picked from commit 61e2bc7)
@vstinner vstinner deleted the curses_fix_window_class_name branch June 15, 2017 23:02
colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
@colesbury
Fix race in test_trashcan_threads in test_gc.py …
eb97914 
See #52
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Fix the pull_request_review webhook. (#52)
aec8995
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@warsaw
Merge branch 'issue52' into 'master' …
59bf56e 
Backport bpo-33254 - contents() returns an Iterable

Closes python#52

See merge request python-devs/importlib_resources!57
isidentical pushed a commit to isidentical/cpython that referenced this pull request Mar 28, 2023
@pablogsal
Merge pull request python#52 from isidentical/last-fstring-status
a0edfb1
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jul 12, 2023
@JuliaPoo @Fidget-Spinner @brandtbucher
Feat: Merge Brandt's Copy and Patch compiler (python#52) …
a6533c1 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Co-authored-by: Brandt Bucher <brandt@python.org>
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Closed
@kcatss kcatss mentioned this pull request Feb 20, 2024
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Closed
This was referenced Feb 11, 2025
Closed
Closed
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Closed
@ngoldbaum ngoldbaum mentioned this pull request Mar 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briancurtin briancurtin briancurtin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @briancurtin @berkerpeksag @Mariatta @the-knights-who-say-ni